On Tuesday 28 April 2015 10:52:32 Simon Hausmann wrote: > There are various options about what we can do with different degrees of > "perfection", but ultimately it's all going to require a compromise. The > option that we are favoring at the moment is two-fold: > > 1) Policy in Qt is to use the Qt wrappers for accessing the environment > (qgetenv, etc.). > > 2) These functions we protect with a mutex. > > Yes, this isn't perfect, because we still include large quantities of code > in src/3rdparty in Qt that has unprotected calls to getenv(). But then > that hasn't stopped us from patching that code in the past.
>From Gerrit, expanded here and there: I don't believe this is the right fix. 1. man putenv on Linux says that since glibc 2.1, putenv is reentrant. In any case, it's almost trivial to fix this in libc (using CAS, as Ossi suggested in a comment on v1 of the patch), but impossible outside. 2. what business does a program have, anyway, of modifying the environment after threads may have started? Such code should be fixed. Making the Qt wrappers "save" could lead to more code doing nonsense instead of being fixed. 3. C functions such as localtime(3) are calling tzset(3) which reads TZ. You may be able to patch 3rd-party code, but you cannot patch libc. Callers of putenv()/setenv() should be fixed to not do so after initial initialisation, ie. when threads may have started. This is how most initialisation in libraries is required to be handled, see e.g. https://www.gnupg.org/documentation/manuals/gpgme/Library-Version-Check.html and I don't see why Qt should do something different from every other C/C++ library on the planet, at least not for such a common problem as library initialisation. Thanks, Marc -- Marc Mutz <marc.m...@kdab.com> | Senior Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company Tel: +49-30-521325470 KDAB - The Qt Experts _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
