On Friday 26 September 2014 13:33:55 Giulio Camuffo wrote:
> Uhm, how did you get that number? A "git log -n 200 |grep Andy|wc -l"
> says 5 to me, four Reviewed-by and one Author, the last one being on
> February 11.
> I don't want to be dismissive of the work he has done on qtwayland,
> but he hasn't been working on it for many months, and on and off for
> even more. Jørgen or Laszlo would be a better fit, imho.

I ran this:

$ git log origin/5.4~200..origin/5.4 | grep Reviewed-by | sort | uniq -c
     32     Reviewed-by: Andrew Knight <[email protected]>
    140     Reviewed-by: Andy Nichols <[email protected]>
      1     Reviewed-by: Elvis Lee <[email protected]>
      1     Reviewed-by: Frederik Gladhorn <[email protected]>
      3     Reviewed-by: Giulio Camuffo <[email protected]>
     50     Reviewed-by: Giulio Camuffo <[email protected]>
      2     Reviewed-by: Gunnar Sletta <[email protected]>
     34     Reviewed-by: Gunnar Sletta <[email protected]>
      1     Reviewed-by: Gunnar Sletta <[email protected]>
     36     Reviewed-by: Jan Arne Petersen <[email protected]>
      1     Reviewed-by: Jędrzej Nowacki <[email protected]>
      2     Reviewed-by: Joerg Bornemann <[email protected]>
    109     Reviewed-by: Jørgen Lind <[email protected]>
      8     Reviewed-by: Jørgen Lind <[email protected]>
     89     Reviewed-by: Laszlo Agocs <[email protected]>
      1     Reviewed-by: Laszlo Papp <[email protected]>
      1     Reviewed-by: Lubomir Rintel <[email protected]>
      1     Reviewed-by: Michael Brasser <[email protected]>
      2     Reviewed-by: Mikko Levonmaa <[email protected]>
      6     Reviewed-by: Oswald Buddenhagen <[email protected]>
      7     Reviewed-by: Paul Olav Tvete <[email protected]>
      2     Reviewed-by: Philippe Coval <[email protected]>
     18     Reviewed-by: Pier Luigi Fiorini <[email protected]>
     26     Reviewed-by: Robin Burchell <[email protected]>
     30     Reviewed-by: Robin Burchell <[email protected]>
     17     Reviewed-by: Samuel Rødal <[email protected]>
      3     Reviewed-by: Sergio Ahumada <[email protected]>
      5     Reviewed-by: Shawn Rutledge <[email protected]>
      1     Reviewed-by: Simo Fält <[email protected]>
      2     Reviewed-by: Thiago Macieira <[email protected]>
      1     Reviewed-by: Tor Arne Vestbø <[email protected]>
      1     Reviewed-by: Vesa Halttunen
      1     Reviewed-by: Yen-Chin Lee <[email protected]>

Problem: origin/5.4~200..origin/5.4 contains more than 200 commits due to 
merging. That's actually 491. I didn't notice this problem because the number 
of reviews per person were all less than 200. Bad coincidence.

If I restrict to actually 200 commits, here's the result:

$ git log -n200 origin/5.4 | grep Reviewed-by | sort | uniq -c          
      4     Reviewed-by: Andrew Knight <[email protected]>
      4     Reviewed-by: Andy Nichols <[email protected]>
      1     Reviewed-by: Frederik Gladhorn <[email protected]>
      1     Reviewed-by: Giulio Camuffo <[email protected]>
     50     Reviewed-by: Giulio Camuffo <[email protected]>
     34     Reviewed-by: Gunnar Sletta <[email protected]>
      1     Reviewed-by: Gunnar Sletta <[email protected]>
      2     Reviewed-by: Jan Arne Petersen <[email protected]>
     22     Reviewed-by: Jørgen Lind <[email protected]>
     48     Reviewed-by: Laszlo Agocs <[email protected]>
      1     Reviewed-by: Michael Brasser <[email protected]>
      2     Reviewed-by: Mikko Levonmaa <[email protected]>
      1     Reviewed-by: Oswald Buddenhagen <[email protected]>
      2     Reviewed-by: Philippe Coval <[email protected]>
      6     Reviewed-by: Pier Luigi Fiorini <[email protected]>
     26     Reviewed-by: Robin Burchell <[email protected]>
     25     Reviewed-by: Robin Burchell <[email protected]>
      1     Reviewed-by: Sergio Ahumada <[email protected]>
      5     Reviewed-by: Shawn Rutledge <[email protected]>
      1     Reviewed-by: Thiago Macieira <[email protected]>
      1     Reviewed-by: Vesa Halttunen
      1     Reviewed-by: Yen-Chin Lee <[email protected]>

And you're right, the last time Andy reviewed anything in qtwayland was 
February/2014.

So, Andy, are you coming back? Or do you want to step down for someone else?

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to