On Wed, Aug 14, 2013 at 8:44 AM, Giuseppe D'Angelo <[email protected]>wrote:
> On 13 August 2013 23:18, Alan Alpert <[email protected]> wrote: > > > > To be clear, this discussion is not about altering the functionality > > of the sanity bot. The current discussion is about the Gerrit > > interface to the sanity review field. If there were any use for that > > field other than the bot, then we wouldn't end up having the two > > conversations so closely tied together. > > >From another prospective: if the contributor can't approve the patch, > what's the point to allow him/her to override the bot's -1? If it's a > mistake, it can be noted in a comment, so the approver can judge it > and eventually override that. > Agree with Giuseppe and Kai. I also think that these decisions are orthogonal, and better up to an approver.
_______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
