I have a crash issue when use QtQuick2 and QtQuick1 together: https://bugreports.qt-project.org/browse/QTBUG-31064 Shall I try out this patch https://codereview.qt-project.org/#change,55521,patchset=5 ?
------------------------------------------------------------------ Wei Yuemin 7FGame -----邮件原件----- 发件人: development-bounces+weiyuemin=7fgame....@qt-project.org [mailto:development-bounces+weiyuemin=7fgame....@qt-project.org] 代表 development-requ...@qt-project.org 发送时间: 2013年5月8日 18:00 收件人: development@qt-project.org 主题: Development Digest, Vol 20, Issue 15 Send Development mailing list submissions to development@qt-project.org To subscribe or unsubscribe via the World Wide Web, visit http://lists.qt-project.org/mailman/listinfo/development or, via email, send a message with subject or body 'help' to development-requ...@qt-project.org You can reach the person managing the list at development-ow...@qt-project.org When replying, please edit your Subject line so it is more specific than "Re: Contents of Development digest..." Today's Topics: 1. Re: CI is back to normal (Sergio Ahumada) 2. Re: 6 conflicting symbols between QtQuick 1 and 2 (Harri Porten) 3. Re: 6 conflicting symbols between QtQuick 1 and 2 (Thiago Macieira) 4. Re: CI is back to normal (Thiago Macieira) 5. Drag 'n' drop with QSqlTableModel (Dmitrii Volosnykh) ---------------------------------------------------------------------- Message: 1 Date: Tue, 7 May 2013 12:07:25 +0200 From: Sergio Ahumada <sergio.ahum...@digia.com> Subject: Re: [Development] CI is back to normal To: <development@qt-project.org> Message-ID: <5188d25d.9040...@digia.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed On 05/07/2013 06:01 AM, Thiago Macieira wrote: > On ter?a-feira, 7 de maio de 2013 03.49.50, F?lt Simo wrote: >> Now when Thiago's DNS zone fix is in, feel free to start staging your >> changes again. The qtbase#dev is still going to fail as long as it is >> missing this Thiago's fix. > > Someone needs to do the merge of stable into dev and push. I'll review > the change when it comes in. > merge from stable into dev here: https://codereview.qt-project.org/55549 -- Sergio Ahumada Release Engineer - Digia, Qt ------------------------------ Message: 2 Date: Tue, 7 May 2013 14:19:57 +0200 (CEST) From: Harri Porten <por...@froglogic.com> Subject: Re: [Development] 6 conflicting symbols between QtQuick 1 and 2 To: development@qt-project.org Cc: r...@froglogic.com Message-ID: <alpine.deb.2.02.1305071417031.21...@greco.froglogic.com> Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Hello Kai, On Tue, 7 May 2013, Koehne Kai wrote: > Since apparently nobody has picked the ball up, I uploaded > > https://codereview.qt-project.org/#change,55521,patchset=5 > > for review, which implements Olivier's suggestion (as far as I understood it). > > Anyhow, would be good if actually someone tests that it resolves the > issue :) Because QtQml and QtDeclarative still exports the same > symbols, even if apps compiled against this patch shouldn't use the > QtQUick1 exports any more. As one of the reporters of the problem we will do that! And sorry about not having been quicker to produce the patch myself. My spare time only allowed for updating my checkout and a rebuild so far. Roy, my colleague who ran into a crash, will try out your patch and report back. Harri. ------------------------------ Message: 3 Date: Tue, 07 May 2013 08:27:02 -0700 From: Thiago Macieira <thiago.macie...@intel.com> Subject: Re: [Development] 6 conflicting symbols between QtQuick 1 and 2 To: development@qt-project.org Message-ID: <15396447.14lW3oXlmC@tjmaciei-mobl2> Content-Type: text/plain; charset="iso-8859-1" On ter?a-feira, 7 de maio de 2013 08.25.48, Koehne Kai wrote: > > -----Original Message----- > > From: development-bounces+kai.koehne=digia....@qt-project.org > > [mailto:development-bounces+kai.koehne=digia....@qt-project.org] On > > Behalf Of Alan Alpert > > Sent: Wednesday, April 24, 2013 8:30 AM > > To: Thiago Macieira > > Cc: development > > Subject: Re: [Development] 6 conflicting symbols between QtQuick 1 and 2 > > > > [...] > > I agree. I'm just waiting for someone to push the patch to codereview. > > Since apparently nobody has picked the ball up, I uploaded > > https://codereview.qt-project.org/#change,55521,patchset=5 > > for review, which implements Olivier's suggestion (as far as I understood > it). > > Anyhow, would be good if actually someone tests that it resolves the issue > :) Because QtQml and QtDeclarative still exports the same symbols, even if > apps compiled against this patch shouldn't use the QtQUick1 exports any > more. Thanks Kai for stepping up. I wonder if we should make the same change to QtQml. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 190 bytes Desc: This is a digitally signed message part. Url : http://lists.qt-project.org/pipermail/development/attachments/20130507/7bff3d47/attachment-0001.bin ------------------------------ Message: 4 Date: Tue, 07 May 2013 08:28:23 -0700 From: Thiago Macieira <thiago.macie...@intel.com> Subject: Re: [Development] CI is back to normal To: development@qt-project.org Message-ID: <1426473.iSEnDUj6FF@tjmaciei-mobl2> Content-Type: text/plain; charset="iso-8859-1" On ter?a-feira, 7 de maio de 2013 12.07.25, Sergio Ahumada wrote: > On 05/07/2013 06:01 AM, Thiago Macieira wrote: > > On ter?a-feira, 7 de maio de 2013 03.49.50, F?lt Simo wrote: > >> Now when Thiago's DNS zone fix is in, feel free to start staging your > >> changes again. The qtbase#dev is still going to fail as long as it is > >> missing this Thiago's fix. > > > > Someone needs to do the merge of stable into dev and push. I'll review the > > change when it comes in. > > merge from stable into dev here: > > https://codereview.qt-project.org/55549 And it's merged, so dev should be normal again. I'll back port the qhostinfo parts of the patch to 4.8. Though I have seen 4.8 integrate since the problem appeared, so either the tests aren't being run or qhostinfo is being ignored. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 190 bytes Desc: This is a digitally signed message part. Url : http://lists.qt-project.org/pipermail/development/attachments/20130507/afbd64de/attachment-0001.bin ------------------------------ Message: 5 Date: Tue, 7 May 2013 22:01:14 +0400 From: Dmitrii Volosnykh <dmitrii.volosn...@gmail.com> Subject: [Development] Drag 'n' drop with QSqlTableModel To: development@qt-project.org Message-ID: <CANHwF-Z0qnkJT4SuagYjhQvL=YY5aJ0Y_UxUVTJXVaaXib=m...@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Hi, all! I am using QTreeView with QAbstractItemModel-inherited model which internally uses QSqlTableModel. I have successfully added DnD support regarding item re-parenting. Unfortunately, data is not copied to the destination row. QAbstractTableModel::dropMimeData() finally calls QAbstractItemModel::decodeData() which tries to write to the newly created row role-data from the old row. For each index it calls QAbstractItemModel::setItemData() which, in turn, depends on setData(). As for QSqlTableModel, setData() has the following lines: if (role != Qt::EditRole) return QSqlQueryModel::setData(index, value, role); This means QAbstractItemModel's default implementation of setData() is called. It always returns false, thus, making QSqlTableModel::setData() and, as a consequence, setItemData() return false. This is reproducible always because of Qt::DisplayRole is also returned in resulting QMap from QAbstractItemModel::itemData(). I am not sure, if this should be considered as a bug and which of the mentioned methods needs to be modified in order to properly treat this case. Obviously, itemData() is a generic method, so it must include Qt::DisplayRole. The same true for QSqlTableModel::setData(): it should fail for Qt::DisplayRole. So, changes should somewhere in between these two. I guess, setItemData() could be reimplemented in QSqlTableModel so that it removes Qt::DisplayRole and call QAbstractTableModel::setItemData() after that. Regards, Dmitrii. ------------------------------ _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development End of Development Digest, Vol 20, Issue 15 ******************************************* _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
