On sábado, 3 de março de 2012 14.30.06, Giuseppe D'Angelo wrote:
> > Ok, I'll rebase/push on master and leave QString changes out
> > (targeting api_changes instead).
>
> All done :)

Now I have to re-review everything because you rebased.

Please stop rebasing. Let the first 4 changes be reviewed and try to go in.
Only if the CI system complains should you make changes now.

Lars: it looks good on a cursory glance, pretty much what had been discussed
for months. I'm pretty tired now having just arrived in SF.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to