On Tuesday, 27 de December de 2011 13.42.10, David Faure wrote:
> On Friday 23 December 2011 17:22:38 Thiago Macieira wrote:
> > QUrl: Always lowercase the scheme
> > Change-Id: I8d467014d22384f1be15fdd746e20b1153a82a4e
> >
> > Do we want this? I think so.
>
> I would say yes, too. This simplifies the checks in application code.
>
> PS: great work on QUrl!
>
> Isn't this going to go to gerrit for review before merging? I'm surprised
> that this is in gitorious branches for now, but I suppose that's because
> topic branches don't really work there iirc.

I'm not allowed to submit to Gerrit. I can only publish as open source.

> What I would like to do with your new QUrl (after this week's vacations) is
> to import it into kdelibs-frameworks, to port kurltest to it and see what
> breaks. Or did you do that already locally? You have my permission to
> import any tests from kurltests that I wrote, into the qurl auto tests, of
> course.

No, I haven't. I've only run the QUrl-related tests in qtbase, so not even the
QtDeclarative tests.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to