@ahrens OK, I've fixed the panic, but I'm not sure it's the correct fix. It
seems that the sha512, edonr, and skein features depend on
SPA_FEATURE_EXTENSIBLE_DATASET but they're not registered with that as a
dependency. Was it intended that they should depend on extensible dataset, or
is that itself a bug? I've added extensible dataset as a dependency for each of
them in a separate commit in this same pull request. Also, assuming the
dependency is intended, I'm not sure if you want a separate dependency array
for each of the new checksum features or a single shared one, since they're all
the same.
https://github.com/ilovezfs/openzfs/commit/5a3f98b338c7c21586ba4c16e7357e5ed0460b58
Also, I was incorrect about the io_bp having ZIO_CHECKSUM_VERIFY. The
ZIO_CHECKSUM_MASK is applied before the io_bp's checksum value is set. So I've
updated the original commit in this pull request to use ZIO_CHECKSUM_MASK
instead of ~ZIO_CHECKSUM_VERIFY, since that seems to be the preexisting way of
clearing the verify flag. Do you like that change, or would you prefer I revert
it back to using ~ZIO_CHECKSUM_VERIFY?
https://github.com/ilovezfs/openzfs/commit/1a832d2a2fe3a187b84f021fc333cf5ba6c974ce
Last, should the new-checksums-extensible-dataset bug get its own issue in the
illumos issue tracker or piggy back on 6541?
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/51#issuecomment-174888023
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
