Moving this review here as well. It was updated according to John's comments.
This fixes the zpool_upgrade_007_pos test case. I have done some cleanup for zpool_upgrade test cases as well, using variable indirect references (which seem cleaner than using eval), making variables local to functions, fixing messages, etc. You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/59 -- Commit Summary -- * 6465 zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_007_pos is broken -- File Changes -- M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/cleanup.ksh (14) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade.cfg (152) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade.kshlib (124) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_001_pos.ksh (10) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_002_pos.ksh (12) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_003_pos.ksh (10) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_004_pos.ksh (33) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_005_neg.ksh (23) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_006_neg.ksh (29) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_007_pos.ksh (15) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_008_pos.ksh (32) M usr/src/test/zfs-tests/tests/functional/cli_root/zpool_upgrade/zpool_upgrade_009_neg.ksh (24) -- Patch Links -- https://github.com/openzfs/openzfs/pull/59.patch https://github.com/openzfs/openzfs/pull/59.diff --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/59
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
