Changes look good. Lots of improvement per line of code changed :-) It would be great if we also had a test for receiving a full stream that's over refquota (which should work due to the "delay_props" changes that were made recently).
I would just ask that you restructure the comment to be less wordy and less of an appeal to authority. Here's my attempt at rewriting it: The clone can't be too much over the head's refquota. To ensure that the entire refquota can be used, we allow one transaction to exceed the the refquota. Therefore, this check needs to also allow for the space referenced to be more than the refquota. The maximum amount of space that one transaction can use on disk is DMU_MAX_ACCESS * spa_asize_inflation. Allowing this overage ensures that we are able to receive a filesystem that exceeds the refquota on the source system. On Fri, Jan 8, 2016 at 2:34 PM, Dan McDonald <[email protected]> wrote: > > > On Jan 7, 2016, at 6:01 PM, Dan McDonald <[email protected]> wrote: > > > > > > Here's the webrev of just the code change: > > > > http://kebe.com/~danmcd/webrevs/son-of-4986/ > > > > And the comments in the one changed file mostly explain things from this > thread. The affected function, dsl_dataset_clone_swap_check_impl(), is > ONLY called by dmu_recv_end_check. Because it's checking for refquota, we > can insert the slack mentioned previously in the mail thread into the > check. I have some long comments to explain things -- I'd appreciate those > being scrutinized carefully as well. > > I've updated the above webrev to include: > > - ZFS Test changes for this situation. > > - An additional fix to have an ASSERT()ion not trip. > > I'm running the ZFS Test Suite as I type this, just to make sure. The new > zfs_receive_012 appears to work. I need to go test stock as well to get a > baseline. > > Appreciate your reviews! > Dan > > > > ------------------------------------------- > illumos-zfs > Archives: https://www.listbox.com/member/archive/182191/=now > RSS Feed: > https://www.listbox.com/member/archive/rss/182191/27179292-bb9021e0 > Modify Your Subscription: > https://www.listbox.com/member/?member_id=27179292&id_secret=27179292-acf9db97 > Powered by Listbox: http://www.listbox.com >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
