@bprotopopov re: dnode_sync(), I'm not sure why we would want to assert that
the birth time is filled in (and it might not be, as @pcd1193182 described).
We might want to assert that the birth time is *not* filled in (and that the
bp's being removed are entirely zeroed out). But I don't think that would be
true either. We might want to make it true by explicitly bzero-ing the
no-longer-bp's. Otherwise it might be possible for the realloc'd object to
have garbage (the old hole BP's) in its bonus buffer. (Though in practice I
think we always overwrite the bonus buffer when reallocating.)
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/46#issuecomment-165865550
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
