Better commit will always get my vote!

I personally find illumos commit messages and the way multiple verified commits get squashed into one very frustrating, as you always have to search for the real information.

    Regards
    Steve

On 12/11/2015 02:57, Prakash Surya wrote:
Would it make sense to include this description in the commit message of the proposed patch? It looks like we're allowing more detailed commit messages in the openzfs repository, so I'd vote to include this explanation along with the diff.

Cheers,
Prakash

On Tue, Nov 10, 2015 at 7:07 PM, Matthew Ahrens <[email protected] <mailto:[email protected]>> wrote:

    https://github.com/openzfs/openzfs/pull/23
    https://www.illumos.org/issues/6393

    This allows to do a full (non-incremental send) and receive it as
    a clone of an existing dataset.  It can leverage nopwrite to share
    blocks with the origin.  This can be used to change the
    relationship of datasets on the target.  For example, maybe on the
    source you have:

    A ---- B ---- C

    And you have sent to the target a full of B, and the incremental B->C:

    B ---- C

    You later realize that you want to have A on the target.  You will
    have to do a full send of A, but nopwrite can save you space on
    the target if you receive it as a clone of B, assuming that A and
    B have some blocks in common:

    B ---- C
     \
      A

    --matt


*illumos-zfs* | Archives <https://www.listbox.com/member/archive/182191/=now> <https://www.listbox.com/member/archive/rss/182191/24401717-fdfe502b> | Modify <https://www.listbox.com/member/?member_id=24401717&id_secret=24401717-b326da58> Your Subscription [Powered by Listbox] <http://www.listbox.com>


_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to