> On Aug. 4, 2015, 1:14 a.m., Matthew Ahrens wrote: > > I don't think this is really the direction we want to go with > > libzfs_core.c; it increases the complexity of the operation and the > > possible error cases. That said, I understand why you want to do it since > > otherwise there's no way to set the name based on the BEGIN record, using > > libzfs_core. Maybe the existing lzc_receive is just the wrong interface, > > and it should take the BEGIN record as an argument, forcing the caller to > > read and decode it (and decide on the name based on it, if desired). We > > could then provide a convenience routine that works like the current > > lzc_receive(). > > > > What do you think?
After our converation on the mailing list I am withdrawing this request and I will create a new one for the approach that you suggested. - Andriy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/232/#review761 ----------------------------------------------------------- On July 15, 2015, 2:36 p.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/232/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 2:36 p.m.) > > > Review request for OpenZFS Developer Mailing List and Matthew Ahrens. > > > Bugs: 6051 > https://www.illumos.org/issues/6051 > > > Repository: illumos-gate > > > Description > ------- > > lzc_receive: add a possibility to take the snapshot name from the stream > > > Diffs > ----- > > usr/src/lib/libzfs_core/common/libzfs_core.c > 22af0f4a7a9fd8ab15cc7880233ba51274ce87d8 > > Diff: https://reviews.csiden.org/r/232/diff/ > > > Testing > ------- > > ZoL, FreeBSD > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
