Hi Will, On Mon, Jul 13, 2015 at 01:57:28PM -0600, Will Andrews wrote: > Hi Ned, > > Do you also plan on upstreaming the ZFSOnLinux fixes for SA corruption bugs?
Thanks for raising that issue. Yes, we really need to upstream those and other bug fixes, though that is mostly independent of this review request. I think there's been some recent off-list discussion about how to streamline the process of getting small patches upstream, and the SA corruption fixes would be a great place to start. Ned > We recently discovered (some of) them when a customer ran into them > via access control changes, only to realize that they had already been > fixed in ZoL some time ago. I would be happy to review these, as I > reviewed the SA code in the process of analyzing the issues. This one > in particular, but there are others: > > https://github.com/zfsonlinux/zfs/commit/4254acb05743dc2175ae76f6e15b0785d4b688fd > > When I reviewed some of the history in ZoL, it looks like there were > also some (much older) changes were made without explanation in other > parts of the ZoL SA code. And some changes were made in illumos-zfs > (and freebsd-zfs) that solved the same problems calculating SA header > sizing in sa_build_layouts()/sa_find_sizes()... > > Thanks, > --Will. > > On Mon, Jul 13, 2015 at 11:36 AM, Ned Bass <[email protected]> wrote: > > Hi, > > > > I've posted an initial implementation of a new pool feature called > > large_dnode for review. The Linux and Illumos ports are posted here: > > > > https://github.com/zfsonlinux/zfs/pull/3542 > > https://reviews.csiden.org/r/231/ > > > > This work is based on a prototype originally developed by Prakash Surya. > > I have extended that prototype to support larger bonus buffers to take > > advantage of the increased dnode size. The goal is to avoid the use of > > spill blocks in order to increase performance of metadata operations, > > reduce memory overhead, and to reduce pool fragmentation. More detailed > > notes can be found in the commit message on github or in the review > > request description. > > > > This is mainly useful today on ZFS on Linux systems that make heavy use > > of extended attributes, such as Lustre servers and systems using > > SELinux. On other platforms, the only use cases I'm aware of that may > > benefit from this today include large ACLs or long symbolic link target > > names. This feature may be desirable on non-Linux platforms in the > > future if applications or features are developed that could make use of > > a larger bonus buffer. > > > > I am very interested in getting feedback, testing, and buy-in from the > > OpenZFS community before we consider merging this work in the Linux > > port. I wasn't able to build and test on Illumos due to my lack of > > familiarity with that environment. If any Illumos folks have time to try > > it out I would be very grateful. > > > > Thanks in advance for your feedback. > > > > Ned > > _______________________________________________ > > developer mailing list > > [email protected] > > http://lists.open-zfs.org/mailman/listinfo/developer _______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
