On 28.03.24 16:48, Kinsey Moore wrote:
This patch set looks good to me. I'd suggest a different file for the versal unless there's a good name that can easily cover both.
The versal BSP doesn't use this driver and seems to have a different hardware UART interface. It uses a BSP-specific driver:
./bsps/aarch64/xilinx-versal/include/dev/serial/versal-uart-regs.h ./bsps/aarch64/xilinx-versal/include/dev/serial/versal-uart.h ./bsps/aarch64/xilinx-versal/dev/serial/versal-uart-polled.c ./bsps/aarch64/xilinx-versal/dev/serial/versal-uart.c I don't think we should mix these two currently independent drivers. -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
