Hi Atharv Dubey,
This is acceptable. However, could you please re-do this to create a
*minimal* patch containing only a small change required to modify what
the hello sample prints? The patch you sent includes many superfluous
changes, including a lot of commented-out lines of code and excessive
blank lines.
Gedare
On Tue, Mar 5, 2024 at 6:49 AM Atharv Dubey <atharvd...@gmail.com> wrote:
>
> Hello , I am Atharv Dubey a sophomore studying ECE at VJTI,Mumbai and here is
> my patch for
> the getting started assignment
>
> diff --git a/testsuites/samples/hello/init.c b/testsuites/samples/hello/init.c
> new file mode 100644
> index 0000000000..2f4029e8d8
> --- /dev/null
> +++ b/testsuites/samples/hello/init.c
> @@ -0,0 +1,89 @@
> +/* SPDX-License-Identifier: BSD-2-Clause */
> +
> +/*
> + * COPYRIGHT (c) 1989-2012.
> + * On-Line Applications Research Corporation (OAR).
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in the
> + * documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
> IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +// #ifdef HAVE_CONFIG_H
> +// #include "config.h"
> +// #endif
> +
> +// #include <rtems.h>
> +// #include <tmacros.h>
> +
> +// const char rtems_test_name[] = "HELLO WORLD";
> +
> +// static rtems_task Init(
> +// rtems_task_argument ignored
> +// )
> +// {
> +// rtems_print_printer_fprintf_putc(&rtems_test_printer);
> +// TEST_BEGIN();
> +// printf( "Hello from Atharv Dubey\n" );
> +// TEST_END();
> +// rtems_test_exit( 0 );
> +// }
> +
> +
> +// /* NOTICE: the clock driver is explicitly disabled */
> +// #define CONFIGURE_APPLICATION_DOES_NOT_NEED_CLOCK_DRIVER
> +// #define CONFIGURE_APPLICATION_NEEDS_SIMPLE_CONSOLE_DRIVER
> +
> +// #define CONFIGURE_MAXIMUM_TASKS 1
> +
> +// #define CONFIGURE_RTEMS_INIT_TASKS_TABLE
> +
> +// #define CONFIGURE_INIT_TASK_ATTRIBUTES RTEMS_FLOATING_POINT
> +
> +// #define CONFIGURE_INITIAL_EXTENSIONS RTEMS_TEST_INITIAL_EXTENSION
> +
> +// #define CONFIGURE_INIT
> +// #include <rtems/confdefs.h>
> +
> +
> +
> +
> +#define CONFIGURE_APPLICATION_NEEDS_CLOCK_DRIVER
> +#define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER
> +
> +#define CONFIGURE_UNLIMITED_OBJECTS
> +#define CONFIGURE_UNIFIED_WORK_AREAS
> +
> +#define CONFIGURE_RTEMS_INIT_TASKS_TABLE
> +
> +#define CONFIGURE_INIT
> +
> +#include <rtems/confdefs.h>
> +#include <rtems.h>
> +#include <stdlib.h>
> +#include <stdio.h>
> +
> +rtems_task Init(
> + rtems_task_argument ignored
> +)
> +{
> + printf( "\nHello World from Atharv Dubey !!!\n" );
> + exit( 0 );
> +}
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
