Coverity warns that (buf[...] & 0x7) can't be bigger than 7. This patch
removes the unnecessary comparison.
---
bsps/shared/dev/rtc/mcp7940m.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/bsps/shared/dev/rtc/mcp7940m.c b/bsps/shared/dev/rtc/mcp7940m.c
index 78a4f21b58..1abc5faaad 100644
--- a/bsps/shared/dev/rtc/mcp7940m.c
+++ b/bsps/shared/dev/rtc/mcp7940m.c
@@ -312,9 +312,8 @@ static int mcp7940m_set_time(int minor, const
rtems_time_of_day *time)
}
if (rv == 0) {
- /* Make sure weekday is in range. Otherwise it's not relevant. */
- if (RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) < 1 ||
- RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) > 7) {
+ /* Make sure weekday is not 0 (out of range). Otherwise it's not used. */
+ if (RTCWKDAY_WKDAY_GET(buf[REG_RTCWKDAY]) < 1) {
buf[REG_RTCWKDAY] &= ~RTCWKDAY_WKDAY_MASK;
buf[REG_RTCWKDAY] |= RTCWKDAY_WKDAY(1);
}
--
2.35.3
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
