/ On Wed, Jun 28, 2023 at 12:17 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote:
> On 28.06.23 19:02, Joel Sherrill wrote: > > On Wed, Jun 28, 2023 at 11:29 AM Sebastian Huber > > <sebastian.hu...@embedded-brains.de > > <mailto:sebastian.hu...@embedded-brains.de>> wrote: > > > > On 28.06.23 18:17, Joel Sherrill wrote: > > > On Wed, Jun 28, 2023 at 11:07 AM Sebastian Huber > > > <sebastian.hu...@embedded-brains.de > > <mailto:sebastian.hu...@embedded-brains.de> > > > <mailto:sebastian.hu...@embedded-brains.de > > <mailto:sebastian.hu...@embedded-brains.de>>> wrote: > > > > > > On 28.06.23 18:05, Joel Sherrill wrote: > > > > The only use was in a test. > > > > > > This function is used by this patch set: > > > > > > https://lists.rtems.org/pipermail/devel/2023-June/075497.html > > <https://lists.rtems.org/pipermail/devel/2023-June/075497.html> > > > > > <https://lists.rtems.org/pipermail/devel/2023-June/075497.html > > <https://lists.rtems.org/pipermail/devel/2023-June/075497.html>> > > > > > > > > > (1) Not in the source repository > > > > I didn't expect that the BSP update integration takes about two > years. > > > > > (2) Even if it was, this code does not belong in the score. It > looks > > > more like BSP support code that some drivers need. > > > > Where would you place this code? > > > > > > If you want it on the cpukit side, dev/shared maybe. Otherwise, > bsps/shared. > > Ok, I move it to cpukit/dev/io. At some point in time we probably need a > bus space API. > Thanks. I am picking at moving all printk related functions into a single location. rtems/score/io.h really should not exist. Do you have any suggestions for a more appropriate location and prefix for _IO_Base64url? If it really is private as indicated by the _IO_ prefix, then it should not be used where it is in the code. It needs a real public facing name and a better location. --joel > > -- > embedded brains GmbH > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.hu...@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fax: +49-89-18 94 741 - 08 > > Registergericht: Amtsgericht München > Registernummer: HRB 157899 > Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler > Unsere Datenschutzerklärung finden Sie hier: > https://embedded-brains.de/datenschutzerklaerung/ >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
