On Fri, Jun 16, 2023 at 2:17 AM Philip Kirkpatrick <p.kirkpatr...@reflexaerospace.com> wrote: > > > > On Fri, Jun 16, 2023 at 7:14 AM Chris Johns <chr...@rtems.org> wrote: >> >> On 15/6/2023 6:16 pm, Philip Kirkpatrick wrote: >> > Thanks for all the good feedback. >> > >> > RE Joel: >> > I'll fix my sloppy formatting that you caught and submit a revised patch. >> > If >> > I'm realistic about my schedule, I probably won't be able to get to it >> > until >> > next week. >> > For xttcps_hw.h, there already is one #ifndef __rtems__ around the >> > #includes, >> > but on review there is another spot where I got lazy and used a #if 0. >> > I'll >> > correct that too. Other than that, the file is unmodified. >> > >> > On the discussion about a shared space, I'll leave that decision up to you. >> > Tell me what you want and I can adjust as needed, or it could be done in a >> > follow-on patch. >> >> Should the RPU BSP be located under bsps/arm/xilinx-rpu? > > > I went back and forth on that decision and decided to keep them combined > since the APU and RPU share a moderate amount of code. However, I can > definitely see an argument that they are different enough to split. If you > want it the other way, I can make that change when I address the other items. > I think we should split it out. Shared code should likely be refactored to arm/shared depending what that is.
I'm not sure that carrying forward a 32-bit arm/xilinx-zynqmp makes sense now that we have a functional aarch64 port. Splitting the RPU out will make it easier to make that decision. >> >> > For the Versal, I've never used that part and am not very familiar with >> > it, but >> > the feedback from Aaron makes it sound like the core is probably pretty >> > similar. One other possible difference would be in the timers but it does >> > look >> > like the Versal has the same TTCs. There just may be a small bit of work >> > to set >> > up the clock input to it. >> >> We would handle the Versal once the BSP has a home. >> >> Chris > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
