On Thu, Mar 23, 2023 at 10:40 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:
> Close #4863.
> ---
> cpukit/include/rtems/score/objectimpl.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/cpukit/include/rtems/score/objectimpl.h
> b/cpukit/include/rtems/score/objectimpl.h
> index c58957ccb5..a1a87b5ccb 100644
> --- a/cpukit/include/rtems/score/objectimpl.h
> +++ b/cpukit/include/rtems/score/objectimpl.h
> @@ -542,9 +542,7 @@ static inline bool _Objects_Is_api_valid(
> uint32_t the_api
> )
> {
> - if ( !the_api || the_api > OBJECTS_APIS_LAST )
> - return false;
> - return true;
> + return ( 1 <= the_api && the_api <= OBJECTS_APIS_LAST );
> }
>
I'd really prefer we avoid compound logical expressions since it
becomes something that needs MCDC analysis at higher levels
of verification/qualification.
Please rewrite using simple logical expressions even if it means
two exit paths at the source leve. It's the same machine code.
--joel
>
> /**
> --
> 2.35.3
>
> _______________________________________________
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
