Hello,

On 06.07.22 13:03, Duc Doan wrote:
Hello Cedric,

Thank you for your feedback. I agree with you that there are places that could 
be optimized out. Here is a new patch for that.

Yes, this looks good, thanks!

One more detail and one question follows:

  static unsigned int EXTIx_IRQn[] = {
      EXTI0_IRQn,
      EXTI1_IRQn,

Detail: You should really mark all constants like that "const": on a STM32 with little RAM, the constants stays in FLASH and that makes a difference.

Finally, sorry for my ignorance - I don't know the overall plan on that project here - but I'm sure that code is 99.5% compatible with the STM32H7. Do you plan to enable it there too?

Thanks,

Cedric


_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to