On 27/10/2021 23:44, Kinsey Moore wrote:
This patch set is a rework of the previous Exception Management API patch set based on feedback from the community. From the last revision: * Everything has been moved out of the RTEMS Classic API namespace * The concept of exception classes have been removed in favor of a direct CPU_Exception_frame to signal mapping function * The added tests have been reworked to accomodate the above changes
Thanks, the patch set looks good overall. I just have some minor comments.
It was not possible to defer the call to raise() to a post-switch action since the post-switch action list is already locked and thus cannot be relocked by calls underneath raise() to add the signal handler call to the list.
You can release the thread state lock in a post-switch action, see _Signal_Action_handler() for an example. You can keep the code as is if you want. I personally would be a bit nervous if someone calls the highly complex raise() function in exception context.
-- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
