Am 02.09.21 um 08:44 schrieb Christian MAUDERER:
Am 02.09.21 um 08:40 schrieb Chris Johns:
On 2/9/21 4:35 pm, Christian MAUDERER wrote:
Am 02.09.21 um 04:57 schrieb Chris Johns:
On 1/9/21 4:24 pm, Christian MAUDERER wrote:
Hello Gedare and Chris,
Am 01.09.21 um 07:55 schrieb Chris Johns:
On 1/9/21 7:26 am, Gedare Bloom wrote:
Sorry, i think libbsd is still a bit slushy, wait for Chris to ok
thx
I planned to wait for Chris work anyway.
I have pushed the changes so this change is OK to push. Thank you
for your
patience and consideration.
Chris
Hello Chris,
that's great news. Thanks a lot for all your great improvements.
I noted that currently your patches are only on 6-freebsd-12. Do you
plan to
have the same (or a similar) patch set on master too? Background of the
question: Normally I would push the patch to both branches. But if
you have a
similar patch set pending for master too, I think it would be a bad
timing if I
push my patch now.
Please push to master. It can be handled as part of that task.
OK. Thanks.
Best regards
Christian
And already a question regarding the new branch: You cleaned up the
rtems-bsd-kernel-namespace.h (which is great).
My patch removes some duplicated functions that are in RTEMS and in
libbsd. The ones in RTEMS are definitively the correct ones and the ones
in libbsd return wrong values sometimes. With your patch, the functions
are now in the namespace header (which is OK).
I tried to regenerate the header using the rtems-kern-symbols. But even
with the --regenerate option like described in the CONTRIBUTING.md, the
symbols are not removed. I can remove them manually and the
rtems-kern-symbols script doesn't change the header if I re-run it. So
I'm quite sure that this is an OK solution. But it somehow feels wrong
to manually change a generated header. Is there something I used wrong?
What I did:
- Re-build libbsd and note that the tests don't link any more.
- run `./rtems-kern-symbols --regenerate --rtems-tools=<path_to_tools>`
Nothing has been changed.
- manually remove the symbols
- re-build (now successfully)
- run `./rtems-kern-symbols --regenerate --rtems-tools=<path_to_tools>`
Nothing has been changed. Symbols are still removed.
- add symbols manually again
- run `./rtems-kern-symbols --regenerate --rtems-tools=<path_to_tools>`
Nothing has been changed. Symbols are still there.
So I think my core question is: Does the tool clean up old symbols or do
I have to do that manually?
Best regards
Christian
--
--------------------------------------------
embedded brains GmbH
Herr Christian MAUDERER
Dornierstr. 4
82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
phone: +49-89-18 94 741 - 18
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
