Things look mostly fine to me. But the last patch:
kern/sys: Add NFSv4 client
* in the buildset configuration, should we use nfsv4 to be explicit?
Or you think 'nfs' is fine?
* freebsd/sys/fs/nfs/nfs_commonkrpc.c: there are random whitespace
changes without guards, and ws changes inside of #ifndef __rtems__.
These might be artifacts of including the .clang-format? Or your
editor got aggressive.
* freebsd/sys/fs/nfsclient/nfs_clvnops.c: ditto
* rtemsbsd/fs/nfsclient/nfs.c: tabs used for indents is inconsistent
with other rtemsbsd sources. Also, you can use the following instead
of memset() with 0:
int some_array[10] = {0};
On Wed, Aug 4, 2021 at 2:53 AM <chr...@rtems.org> wrote:
>
> Hi,
>
> This the first group of patches for the NFSv4 port. This is the only
> part of the patches posted to devel, the complete series of patches
> can be downloaded from:
>
> https://ftp.rtems.org/pub/rtems/people/chrisj/nfsv4/patches/4/
>
> I have pushed the patch series to my personal repo:
>
> https://git.rtems.org/chrisj/rtems-libbsd.git/?h=4475-p4-4475-nfs
>
> The changes here:
>
> 1. Kernel symbols use a FreeBSD format (tab)
>
> 2. Fixed the lock to be as small as possible
>
> 3. Thread name is reference
>
> 4. Added code is now in the FreeBSD format
>
> 5. Other minor changes as highligthed in the first review
>
> Chris
>
> _______________________________________________
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
