Thanks for the review. I have updated ticket 3053 and sent v5. Can you please check?
On Tue, Jun 15, 2021 at 4:06 PM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 11/06/2021 11:47, Richi Dubey wrote: > > diff --git a/cpukit/score/src/schedulerstrongapa.c > b/cpukit/score/src/schedulerstrongapa.c > > index dcfb55601a..5aaa8dbd1a 100644 > > --- a/cpukit/score/src/schedulerstrongapa.c > > +++ b/cpukit/score/src/schedulerstrongapa.c > > @@ -3,29 +3,35 @@ > > * > > * @ingroup RTEMSScoreSchedulerStrongAPA > > * > > - * @brief This source file contains the implementation of > > - * _Scheduler_strong_APA_Add_processor(), > > - * _Scheduler_strong_APA_Ask_for_help(), > _Scheduler_strong_APA_Block(), > > - * _Scheduler_strong_APA_Initialize(), > > - * _Scheduler_strong_APA_Node_initialize(), > > - * _Scheduler_strong_APA_Reconsider_help_request(), > > - * _Scheduler_strong_APA_Remove_processor(), > _Scheduler_strong_APA_Unblock(), > > - * _Scheduler_strong_APA_Update_priority(), > > - * _Scheduler_strong_APA_Withdraw_node(), and > _Scheduler_strong_APA_Yield(). > > + * @brief Strong APA Scheduler Implementation > > */ > > Could you please update the Doxygen comment instead of replacing it. At > least make it a proper sentence. > > > > > /* > > - * Copyright (c) 2013, 2016 embedded brains GmbH. All rights reserved. > > + * SPDX-License-Identifier: BSD-2-Clause > > The SPDX-License-Identifier have to be in the first line of the file. > Please mention the license change in the commit messages and update the > corresponding ticket. > > -- > embedded brains GmbH > Herr Sebastian HUBER > Dornierstr. 4 > 82178 Puchheim > Germany > email: sebastian.hu...@embedded-brains.de > phone: +49-89-18 94 741 - 16 > fax: +49-89-18 94 741 - 08 > > Registergericht: Amtsgericht München > Registernummer: HRB 157899 > Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler > Unsere Datenschutzerklärung finden Sie hier: > https://embedded-brains.de/datenschutzerklaerung/ >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
