Well, since you pushed 2/2, you should push 1/2 (unless there are different patch series?)
We should prefer to review and merge all/none of a series. On Thu, May 20, 2021 at 9:56 PM Gedare Bloom <ged...@rtems.org> wrote: > > Seems fine by me, but wait until Monday to let anyone complain if they want. > > On Thu, May 20, 2021 at 5:35 PM Vijay Kumar Banerjee <vi...@rtems.org> wrote: > > > > Hi, > > > > > > On Thu, Apr 22, 2021 at 12:21 PM Gedare Bloom <ged...@rtems.org> wrote: > > > > > > I guess there's not much else to do here without a network stack API > > > to manipulate the network task(s). > > > > > > Is there a ticket to fix the lack of ability to configure and access > > > network task priorities? I'm guessing libbsd and lwip will both need > > > to figure out how to do this somehow. The design isn't obvious to me > > > right now. > > > > > > > I somehow missed this before. > > I raised a ticket: https://devel.rtems.org/ticket/4436 > > Is this ok to be pushed with this ticked number mentioned in the comment? > > > > > > Best regards, > > Vijay > > > > > On Thu, Apr 22, 2021 at 12:07 PM Vijay Kumar Banerjee <vi...@rtems.org> > > > wrote: > > > > > > > > Ping :) > > > > > > > > On Tue, Apr 13, 2021 at 11:45 PM Vijay Kumar Banerjee <vi...@rtems.org> > > > > wrote: > > > > > > > > > > Set the priority manually to make telnetd compatible with the > > > > > --- > > > > > cpukit/telnetd/telnetd.c | 11 +---------- > > > > > 1 file changed, 1 insertion(+), 10 deletions(-) > > > > > > > > > > diff --git a/cpukit/telnetd/telnetd.c b/cpukit/telnetd/telnetd.c > > > > > index b8adec297a..7dad2f2f92 100644 > > > > > --- a/cpukit/telnetd/telnetd.c > > > > > +++ b/cpukit/telnetd/telnetd.c > > > > > @@ -58,10 +58,6 @@ > > > > > #include <rtems/thread.h> > > > > > #include <rtems/userenv.h> > > > > > > > > > > -#ifdef RTEMS_NETWORKING > > > > > -#include <rtems/rtems_bsdnet.h> > > > > > -#endif > > > > > - > > > > > #define TELNETD_EVENT_SUCCESS RTEMS_EVENT_0 > > > > > > > > > > #define TELNETD_EVENT_ERROR RTEMS_EVENT_1 > > > > > @@ -400,12 +396,7 @@ rtems_status_code rtems_telnetd_start(const > > > > > rtems_telnetd_config_table* config) > > > > > ctx->server_socket = -1; > > > > > LIST_INIT(&ctx->free_sessions); > > > > > > > > > > - /* Check priority */ > > > > > -#ifdef RTEMS_NETWORKING > > > > > - if (ctx->config.priority == 0) { > > > > > - ctx->config.priority = rtems_bsdnet_config.network_task_priority; > > > > > - } > > > > > -#endif > > > > > + /* Set priority */ > > > > > if (ctx->config.priority == 0) { > > > > > ctx->config.priority = 100; > > > > > } > > > > > -- > > > > > 2.26.2 > > > > > _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
