looks good.
On Wed, Apr 14, 2021 at 9:33 AM Joel Sherrill <[email protected]> wrote: > > I'll pick on you. :) > > Please don't use the "title" that says "Fix ABC". There has to be a better > description. > > Hopefully someone will ack the technical. I think it is right. > > --joel > > On Wed, Apr 14, 2021 at 9:20 AM Ryan Long <[email protected]> wrote: >> >> ping >> >> -----Original Message----- >> From: Ryan Long <[email protected]> >> Sent: Friday, March 12, 2021 8:56 AM >> To: [email protected] >> Cc: Ryan Long <[email protected]> >> Subject: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID >> #1399709) >> >> CID 1399709: Dereference after null check in >> rtems_trace_buffering_shell_save(). >> >> Closes #4329 >> --- >> cpukit/libmisc/shell/main_rtrace.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/cpukit/libmisc/shell/main_rtrace.c >> b/cpukit/libmisc/shell/main_rtrace.c >> index 753ab9d..e4f59c4 100644 >> --- a/cpukit/libmisc/shell/main_rtrace.c >> +++ b/cpukit/libmisc/shell/main_rtrace.c >> @@ -473,6 +473,7 @@ rtems_trace_buffering_shell_save (int argc, char *argv[]) >> { >> close (out); >> printf ("error: no memory\n"); >> + return 1; >> } >> >> memset (buf, 0, SAVE_BUF_SIZE); >> -- >> 1.8.3.1 >> >> _______________________________________________ >> devel mailing list >> [email protected] >> http://lists.rtems.org/mailman/listinfo/devel > > _______________________________________________ > devel mailing list > [email protected] > http://lists.rtems.org/mailman/listinfo/devel _______________________________________________ devel mailing list [email protected] http://lists.rtems.org/mailman/listinfo/devel
