On Tue, Apr 6, 2021 at 10:56 AM Gedare Bloom <ged...@rtems.org> wrote: > > looks ok, it's a lot to try to process though. > > In a future patch it would be good to provide more useful names, I > don't know what 'ha' and 'la' mean, if anything. at least 'a' I > understand to be an address. > > Also, the typedef with appending _t at the end should be removed, _t > is reserved by POSIX.
Agreed. I'll file tickets. > > And I don't know why the _m is being appended, I guess it is denoted > member variables? I'm used to seeing it as a prefix rather than a > suffix, if it gets used at all. A few more C++ issues to add to the > backlog. As far as I can tell, yes. I've seen it done both ways in the past. This codebase will need a lot of work to get its code style consistent. Thanks, Alex _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
