Ok, thanks.

On Mon, Mar 29, 2021 at 2:19 PM Alex White <alex.wh...@oarcorp.com> wrote:
>
> On Sat, Mar 27, 2021 at 9:46 AM Gedare Bloom <ged...@rtems.org> wrote:
> >
> > On Fri, Mar 12, 2021 at 10:17 AM Alex White <alex.wh...@oarcorp.com> wrote:
> > >
> > > ---
> > >  tester/rtems/testing/coverage/symbol-sets.ini | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tester/rtems/testing/coverage/symbol-sets.ini 
> > > b/tester/rtems/testing/coverage/symbol-sets.ini
> > > index 9617dd8..52e25ff 100644
> > > --- a/tester/rtems/testing/coverage/symbol-sets.ini
> > > +++ b/tester/rtems/testing/coverage/symbol-sets.ini
> > > @@ -29,7 +29,7 @@
> > >  #
> > >
> > >  [symbol-sets]
> > > -sets = 
> > > score,rtems,sapi,posix,librfs,libpipe,libdosfs,libimfs,libjffs2,libcsupport,libbspcmdline,libcpuuse,libstackchk,libfsmount,libstringto,libdevnull,libdumpbuf,libuntar,libblock,libcrypt,libmd,libstdthreads
> > > +sets = 
> > > score,rtems,sapi,posix,librfs,libpipe,libdosfs,libimfs,libjffs2,libcsupport,libbspcmdline,libcpuuse,libstackchk,libfsmount,libstringto,libdevnull,libdumpbuf,libuntar,libblock,libcrypt,libmd,libstdthreads,libtrace
> > >
> > ok, but this is really ugly. is the comma-separated list with no
> > whitespace mandatory, or can it be reformatted in a follow-up patch?
>
> Currently, it is mandatory because the coverage.py script does not remove 
> whitespace when processing the values, it simply splits them on ',' 
> characters.
>
> It can be reformatted in a follow-up patch to look something like this:
>
> sets = 
> score,rtems,sapi,posix,librfs,libpipe,libdosfs,libimfs,libjffs2,libcsupport,
>         libbspcmdline,libcpuuse,libstackchk,libfsmount,libstringto,libdevnull,
>         libdumpbuf,libuntar,libblock,libcrypt,libmd,libstdthreads,libtrace
>
> As long as subsequent lines are indented (to comply with Python's 
> ConfigParser format), it should work fine assuming logic is added to call 
> strip() on the values in the parse() method of the symbol_parser class in 
> coverage.py.
>
> >
> > >  [libraries]
> > >  score         = @BUILD-TARGET@/@BSP@/cpukit/score/src
> > > @@ -76,4 +76,5 @@ libblock      = @BUILD-TARGET@/@BSP@/cpukit/libblock/src
> > >  libcrypt      = @BUILD-TARGET@/@BSP@/cpukit/libcrypt
> > >  libmd         = @BUILD-TARGET@/@BSP@/cpukit/libmd
> > >  libstdthreads = @BUILD-TARGET@/@BSP@/cpukit/libstdthreads
> > > +libtrace      = @BUILD-TARGET@/@BSP@/cpukit/libtrace/record
> > >  #zlib          = @BUILD-TARGET@/@BSP@/cpukit/zlib
> > > --
> > > 2.27.0
> > >
> > > _______________________________________________
> > > devel mailing list
> > > devel@rtems.org
> > > http://lists.rtems.org/mailman/listinfo/devel
> > _______________________________________________
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to