Am 01.12.20 um 13:45 schrieb Peter Dufault:


On Nov 30, 2020, at 18:07 , Gedare Bloom <ged...@rtems.org> wrote:

Aren't nearly all shell commands at least a bit unsafe? And we don't
have a lot of commands that have to be explicitly turned on if
CONFIGURE_SHELL_COMMANDS_ALL is already set. I found only networking
commands.

That seems accurate, you can go ahead with the approach you took then. It seems 
to be mostly consistent with the state of practice.



I was surprised at the need to enable each command instead of adding all I2C 
commands with a single enable.  I don't think code overhead is an issue.  If 
you're testing I2C from the shell I'm not sure when it's important to have only 
e.g. i2cget but not i2cset.

It's like with a lot of other commands in RTEMS. You can have all or you enable them one by one. I had a look and we have (for example) also no group for file commands like rm, mv, cp, ls.

The only group I found (beneath CONFIGURE_SHELL_COMMANDS_ALL) is the CONFIGURE_SHELL_COMMANDS_ALL_NETWORKING. I'm not sure whether it would be a good idea to start a new group now.

Best regards

Christian


Peter
-----------------
Peter Dufault
HD Associates, Inc.      Software and System Engineering

This email is delivered through the public internet using protocols subject to 
interception and tampering.


_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


--
--------------------------------------------
embedded brains GmbH
Herr Christian MAUDERER
Dornierstr. 4
82178 Puchheim
Germany
email: christian.maude...@embedded-brains.de
phone: +49-89-18 94 741 - 18
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to