On 20/11/2020 18:56, Joel Sherrill wrote:

It should be implemented. File a ticket if you don't want to do it now.

But don't delete it. It should be there for completeness. I would have thought there was code that iterated over all the APIs and classes and used it. What is being used instead?

This function was added by

commit 6c06288f6452da96fa630f1482aeaaba5d217531
Author: Joel Sherrill <joel.sherr...@oarcorp.com>
Date:   Tue Jan 29 21:52:21 2008 +0000

    2008-01-29      Joel Sherrill <joel.sherr...@oarcorp.com>

            * itron/src/exd_tsk.c, itron/src/task.c, libmisc/capture/capture.c,
            libmisc/monitor/mon-config.c, libmisc/monitor/mon-driver.c,
            libmisc/monitor/mon-itask.c, libmisc/monitor/mon-monitor.c,
            libmisc/monitor/mon-mpci.c, libmisc/monitor/mon-object.c,
            libmisc/monitor/mon-symbols.c, posix/src/cancelrun.c,
            posix/src/pthreadexit.c, rtems/Makefile.am, rtems/preinstall.am,
            rtems/include/rtems.h, rtems/include/rtems/rtems/support.h,
            rtems/inline/rtems/rtems/tasks.inl, rtems/src/eventmp.c,
            rtems/src/msgmp.c, rtems/src/partmp.c, rtems/src/regionmp.c,
            rtems/src/rtemsobjectgetname.c, rtems/src/semmp.c,
            rtems/src/signalmp.c, rtems/src/taskdelete.c, rtems/src/taskmp.c,
            rtems/src/timerserver.c, score/Makefile.am,
            score/include/rtems/score/object.h,
            score/inline/rtems/score/object.inl, score/src/Unlimited.txt,
            score/src/objectgetnameasstring.c,
            score/src/threadqextractwithproxy.c: Add new Object Services
            collection. This changed the name of a few previously public but
            undocumented services and added a some new services.
            * rtems/include/rtems/rtems/object.h, rtems/src/rtemsbuildid.c,
            rtems/src/rtemsbuildname.c, rtems/src/rtemsobjectapimaximumclass.c,
            rtems/src/rtemsobjectapiminimumclass.c,
            rtems/src/rtemsobjectgetapiclassname.c,
            rtems/src/rtemsobjectgetapiname.c,
            rtems/src/rtemsobjectgetclassicname.c,
            rtems/src/rtemsobjectgetclassinfo.c,
            rtems/src/rtemsobjectidapimaximum.c,
            rtems/src/rtemsobjectidapiminimum.c, rtems/src/rtemsobjectidgetapi.c,             rtems/src/rtemsobjectidgetclass.c, rtems/src/rtemsobjectidgetindex.c,             rtems/src/rtemsobjectidgetnode.c, rtems/src/rtemsobjectsetname.c,
            score/src/objectapimaximumclass.c, score/src/objectgetinfo.c,
            score/src/objectgetinfoid.c, score/src/objectsetname.c: New files.
            * rtems/src/rtemsidtoname.c: Removed.

Nobody noticed that this function is missing in the last twelve years. What is the differences to:

/**
 * @brief Get Highest Valid Class Value
 *
 * This method returns the highest valid value Class for the
 * specified @a api. Each API supports a different number
 * of object classes.
 *
 * @param[in] api is the API to obtain the maximum class of
 *
 * @retval This method returns the greatet valid value for
 *         class number for the specified @a api.
 */
int rtems_object_api_maximum_class(
  int api
);

To me the removed function looks like some fragment left over from development.


On Fri, Nov 20, 2020 at 11:47 AM Sebastian Huber <sebastian.hu...@embedded-brains.de <mailto:sebastian.hu...@embedded-brains.de>> wrote:

    This function has no implementation.  It is documented in the RTEMS
    Classic API Guide.
    ---
     cpukit/include/rtems/rtems/object.h | 17 -----------------
     1 file changed, 17 deletions(-)

    diff --git a/cpukit/include/rtems/rtems/object.h
    b/cpukit/include/rtems/rtems/object.h
    index 8e8bfbf293..77c13f473f 100644
    --- a/cpukit/include/rtems/rtems/object.h
    +++ b/cpukit/include/rtems/rtems/object.h
    @@ -285,23 +285,6 @@ int rtems_object_api_maximum_class(
       int api
     );

    -
    -/**
    - * @brief Get Highest Valid Class Value
    - *
    - * This method returns the lowest valid value Class for the
    - * specified @a api. Each API supports a different number
    - * of object classes.
    - *
    - * @param[in] api is the API to obtain the maximum class of
    - *
    - * @retval This method returns the least valid value for
    - *         class number for the specified @a api.
    - */
    -int rtems_object_id_api_maximum_class(
    -  int api
    -);
    -
     /**
      * @brief Get API Name
      *
-- 2.26.2

    _______________________________________________
    devel mailing list
    devel@rtems.org <mailto:devel@rtems.org>
    http://lists.rtems.org/mailman/listinfo/devel
    <http://lists.rtems.org/mailman/listinfo/devel>

--
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier: 
https://embedded-brains.de/datenschutzerklaerung/

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to