Hi Kinsey,
Thanks for reviewing the patch...
On Sun, Nov 15, 2020 at 9:51 AM Kinsey Moore <kinsey.mo...@oarcorp.com>
wrote:
> Odd, "gic_version" works just fine in the version of qemu-system-aarch64
> in the Debian package repos which is what I've been testing against. As
> you've provided in the patch, the official option name is "gic-version" and
> that also works. Just out of curiosity, does this cause Qemu to fail for
> you?
Qemu 5.0 crashes with:
```
qemu-system-aarch64: Property '.gic_version' not found
```
>
>
Either way, this change looks good to me.
>
Thanks, I'll push.
Best regards,
Vijay
>
> Kinsey
>
> -----Original Message-----
> From: devel <devel-boun...@rtems.org> On Behalf Of Vijay Kumar Banerjee
> Sent: Saturday, November 14, 2020 14:51
> To: devel@rtems.org
> Subject: [PATCH rtems-tools] bsps/a53_*: Fix typo in qemu options
>
> ---
> tester/rtems/testing/bsps/a53_ilp32_qemu.ini | 2 +-
> tester/rtems/testing/bsps/a53_lp64_qemu.ini | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tester/rtems/testing/bsps/a53_ilp32_qemu.ini
> b/tester/rtems/testing/bsps/a53_ilp32_qemu.ini
> index 6dfc883..3beba06 100644
> --- a/tester/rtems/testing/bsps/a53_ilp32_qemu.ini
> +++ b/tester/rtems/testing/bsps/a53_ilp32_qemu.ini
> @@ -35,4 +35,4 @@
> bsp = a53_ilp32_qemu
> arch = aarch64
> tester = %{_rtscripts}/qemu.cfg
> -bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine
> virt,gic_version=3 -cpu cortex-a53 -m 4096
> +bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine
> +virt,gic-version=3 -cpu cortex-a53 -m 4096
> diff --git a/tester/rtems/testing/bsps/a53_lp64_qemu.ini
> b/tester/rtems/testing/bsps/a53_lp64_qemu.ini
> index f29ab13..1b89284 100644
> --- a/tester/rtems/testing/bsps/a53_lp64_qemu.ini
> +++ b/tester/rtems/testing/bsps/a53_lp64_qemu.ini
> @@ -35,4 +35,4 @@
> bsp = a53_lp64_qemu
> arch = aarch64
> tester = %{_rtscripts}/qemu.cfg
> -bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine
> virt,gic_version=3 -cpu cortex-a53 -m 4096
> +bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine
> +virt,gic-version=3 -cpu cortex-a53 -m 4096
> --
> 2.21.1
>
> _______________________________________________
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
