On 11/11/2020 18:23, Gedare Bloom wrote:

  #if defined(__GNUC__)
-  #define RTEMS_PREDICT_TRUE( _exp ) __builtin_expect( ( _exp ), 1 )
+  #define RTEMS_PREDICT_TRUE( _exp ) __builtin_expect( ( _exp ), 0 )
This looks like a typo, it should be 1 not 0?

Oh, yes. Thanks a lot for this thorough review!

Unfortunately, a test for this macro would probably require to scan the generated machine code.

--
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax:   +49-89-18 94 741 - 08
PGP: Public key available on request.

embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier: 
https://embedded-brains.de/datenschutzerklaerung/

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to