On 29/9/20 9:37 pm, Sebastian Huber wrote: > On 28/09/2020 17:24, Kinsey Moore wrote: > >> +/* TODO(kmoore) The current implementation here assumes that SP is not >> misaligned */ > Maybe add a ticket for this TODO and reference it in the comment. >> + .macro JUMP_HANDLER >> + mov x0, #0x7f /* mask to use in BIC, lower 7 bits */ >> + bic x0, lr, x0 /* lr contains PC, mask off to the base of >> the current vector */ >> + ldr x0, [x0, #0x78] /* load address from the last word in >> the vector */ >> + blr x0 /* branch and link to address in x0, no reason to >> save current LR since it has already been saved and current contents are >> junk */ >> + ldp x0, lr, [sp], #16 /* pop x0,lr from stack */ >> + eret /* return from exception */ > Some lines are longer than 79 characters. I spotted also // comments. I have > nothing against // comments in general, but before we introduce them, it would > be good to update the coding style.
It seems Kinsey wrote the code with C comments so lets say use just C comments ... https://developer.arm.com/documentation/100933/0100/AArch64-exception-vector-table Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
