On 17/09/2020 23:35, Chris Johns wrote: > On 17/9/20 10:51 pm, Joel Sherrill wrote: >> I think I'm ok on all three of these patches but some >> comments on the shell script. I can see where this is a >> tedious but important check. And it can be improved easily. >> >> Since this smells like something Chris would poke me f >> or and call a "Joel script" :) > > Haha ... > > This patch is only for the 5-freesd-12 branch and a script is fine. The script > has made think for the master and 6-freebsd-12 branches libbsd.py should be > taught to handle licenses so these are copied across as part of the import. > > Chris >
Hello Chris and Joel, I agree that this script is an ugly one. It has been hacked together when I needed to import the license files and I didn't wanted to throw it out of the window because I thought it might could be useful to find some more missing license files in the future. Please note that this script is already on master since quite a long time and that I only cherry-picked the commits for the 5-freebsd-12 branch (and adapted the import patch to import the right version). So thanks for the suggestions Joel but shouldn't these changes then be an extra patch? Chris: You mentioned that libbsd.py should be taught to handle licenses. Do you plan anything into that direction? In that case touching the script wouldn't be really useful. Best regards Christian -- -------------------------------------------- embedded brains GmbH Herr Christian Mauderer Dornierstr. 4 D-82178 Puchheim Germany email: christian.maude...@embedded-brains.de Phone: +49-89-18 94 741 - 18 Fax: +49-89-18 94 741 - 08 PGP: Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
