On Wed, Aug 12, 2020 at 7:07 AM Aschref Ben-Thabet < aschref.ben-tha...@embedded-brains.de> wrote:
> From: Aschref Ben Thabet <aschref.ben-tha...@embedded-brains.de> > > replace strncpy with memcpy to silence this warning and free the > allocated memory block. > I don't see a call to strncpy being replaced. Maybe I need coffee. I see an RTEMS test assert strcmp. Silence what warning? I do not think it is appropriate to replace str*cpy with memcpy. What is the warning? --- > testsuites/psxtests/psxndbm01/init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/testsuites/psxtests/psxndbm01/init.c > b/testsuites/psxtests/psxndbm01/init.c > index b524aff0df..658af58df3 100644 > --- a/testsuites/psxtests/psxndbm01/init.c > +++ b/testsuites/psxtests/psxndbm01/init.c > @@ -216,11 +216,12 @@ rtems_task Init(rtems_task_argument ignored) > get_phone_no = dbm_fetch( db, name2 ); > rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO2 ) > == 0 ); > > - puts( "Fetch non-existing record and confirm error." ); > + puts( "Fetch non-existing record and confirm error." ); > I don't see a change here. And while you are here non-existing isn't a word. It should be "nonexistent" > test_strings = (char*)malloc(6); > memcpy( test_strings, "Hello", 5 ); > > test_strings[5] = '\0'; > + free(test_strings); > > /* The data pointed by test_string is now pointed by key.dptr */ > key.dptr = test_strings; > -- > 2.26.2 > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
