I have replied to the comment please have a look. https://github.com/gs-niteesh/rtems-release/commit/58ed0cb3fc1f33f12de8e550979371a51e322754#r38841918
Thanks, Niteesh On Thu, Apr 30, 2020 at 5:58 AM Chris Johns <chr...@rtems.org> wrote: > It looks like there is something wrong with the rtems.org mail lists. I > have pinged Amar to have a look. > > On 30/4/20 4:45 am, Niteesh G. S. wrote: > > Please have a look at this if you missed it previously. :) > > > > Thanks, > > Niteesh. > > > > On Tue, Apr 28, 2020 at 11:30 PM Niteesh G. S. <niteesh...@gmail.com > > <mailto:niteesh...@gmail.com>> wrote: > > > > This is my first time writing shell scripts. If something seems like > > a hack or if there is a better of doing it. Please let me know. > > > > > https://github.com/gs-niteesh/rtems-release/commit/70cbb5418ba68992a910844c3d6450ef4db17579 > > > https://github.com/gs-niteesh/rtems-release/commit/58ed0cb3fc1f33f12de8e550979371a51e322754 > > > > On Tue, Apr 28, 2020 at 3:51 PM Chris Johns <chr...@rtems.org > > <mailto:chr...@rtems.org>> wrote: > > > > On 28/4/20 6:26 pm, Niteesh G. S. wrote: > > > On Tue, Apr 28, 2020 at 8:10 AM Chris Johns <chr...@rtems.org > > <mailto:chr...@rtems.org> > > > <mailto:chr...@rtems.org <mailto:chr...@rtems.org>>> wrote: > > > > > > On 28/4/20 11:51 am, Niteesh G. S. wrote: > > > > > > > > > > https://github.com/gs-niteesh/rtems-release/commit/8666bcd66066512f91194660817cd42cbb8c76e9 > > > > If it is okay for you, then I will send the patch to > > the mailing > > > list. > > > > > > The repos list is now just the package names and the > > branch script > > > as it > > > is expects the repo name, i.e. .git at the end. > > > > > > > > > How should I do this? Shall I iterate over all the repos in > > rtems_repo > > > variable > > > and append '.git' to the end? This will happen right after the > > > declaration of the > > > variable. > > > > Yes this is fine. > > > > > Also the rtems-releases repo needs to be added to the > > list of repos > > > (and > > > not packages). > > > > > > Done. > > > We should avoid branching this repo, right? > > > > No lets branch it. We might as well be consistent in how we > > manage repos > > in the project. It makes procedures in the eng manual easier, > > i.e. just > > one procedure to cover them all. > > > > > I think it would be a good idea to be able to run this > > script which > > > means a way to switch the git clone from ssh to the git > > protocol. I > > > recently added command line support to rtems-release so I > > suggest you > > > borrow that code and add an option so you can switch the > > git protocol > > > and test. I would also add a switch to push, i.e. by > > default a push is > > > not done. > > > > > > Should we take the URL from the user similar to how it is > > done in > > > rtems-release > > > or just ask if he wants to test? In this case, the user has > > to just pass > > > -t or something > > > to cmd line and it would download the sources from > > git://git.rtems.org/ <http://git.rtems.org/> > > > <http://git.rtems.org/> > > > > Hmm lets start with an option to switch between the git and ssh > > protocols. I cannot see a use case where there is a completely > > different > > location for the repos. If that does arise it can be sorted out > > then. > > > > Chris > > >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
