On 16/04/2020 10:44, Vijay Kumar Banerjee wrote: > > > On Thu, Apr 16, 2020 at 2:08 PM Christian Mauderer > <christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de>> wrote: > > On 16/04/2020 10:27, Vijay Kumar Banerjee wrote: > > > > > > On Thu, Apr 16, 2020 at 1:51 PM Christian Mauderer > > <christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de> > > <mailto:christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de>>> wrote: > > > > > > > > On 16/04/2020 09:41, Christian Mauderer wrote: > > > On 16/04/2020 09:21, Vijay Kumar Banerjee wrote: > > >> > > >> > > >> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer > > >> <christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de> > > <mailto:christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de>> > > >> <mailto:christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de> > > <mailto:christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de>>>> wrote: > > >> > > >> Hello Vijay, > > >> > > >> On 16/04/2020 09:04, Vijay Kumar Banerjee wrote: > > >> > Hi Christian, > > >> > > > >> > I'm not able to build libbsd with this patch. I'm > getting the > > >> following > > >> > error: > > >> > ``` > > >> > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: > > fatal error: > > >> > arm/freescale/imx/imx_ccmvar.h: No such file or directory > > >> > #include <arm/freescale/imx/imx_ccmvar.h> > > >> > ``` > > >> > From git blame I got to know that this file was > introduced > > by the > > >> commit > > >> > from this patch. > > >> > Am I missing something or is it really a bug? > > >> > > >> Thanks for the report. On what BSP and which exact > commit did > > you try to > > >> build? I had no trouble building the patch set from a clean > > checkout > > >> yesterday before committing it. > > >> > > >> I did a pull from the upstream master and tried the build on > > >> arm/beagleboneblack > > >> I see that the header file is not present in the freebsd/ > directory > > >> ``` > > >> rtems-libbsd $>find -iname imx_ccmvar.h > > >> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h > > >> ``` > > > > > > Hello Vijay, > > > > > > that's quite clearly a bug that I introduced. I'll create a > patch. > > > > > > The imx_ccmvar.h is a file that is provided by the BSP I > used for > > testing. > > > > > > Best regards > > > > > > Christian > > > > I've sent a patch. Can you test it? > > > > Sure. I don't see the patch on the list yet, I'll test it as soon > as it > > comes :) > > Odd. It's already sent out and I CCd you directly. But the archive > hasn't seen it either. To be sure, I attached the patch here. > > This patch fixed the issue and the build completes successfully. Thanks. > I'll also comment on the patch when it hits the list.
Should have reached the list now: https://lists.rtems.org/pipermail/devel/2020-April/059395.html > > > > > > > > >> > > >> > > > >> > Sorry for commenting on the patch that has already been > > committed, > > >> > please let me know of > > >> > the preferred way to comment on a commit if this is > not the > > right way. > > >> > > >> No problem. That's exactly the right way to do it. If there > > is a bug it > > >> has to be solved and everyone should know that someone is > > having a look > > >> at it. > > >> > > >> Best regards > > >> > > >> Christian > > >> > [...] > > -- > -------------------------------------------- > embedded brains GmbH > Herr Christian Mauderer > Dornierstr. 4 > D-82178 Puchheim > Germany > email: christian.maude...@embedded-brains.de > <mailto:christian.maude...@embedded-brains.de> > Phone: +49-89-18 94 741 - 18 > Fax: +49-89-18 94 741 - 08 > PGP: Public key available on request. > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. > -- -------------------------------------------- embedded brains GmbH Herr Christian Mauderer Dornierstr. 4 D-82178 Puchheim Germany email: christian.maude...@embedded-brains.de Phone: +49-89-18 94 741 - 18 Fax: +49-89-18 94 741 - 08 PGP: Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
