I sent this patch a few days ago. if anyone could look at it. the code was tested by dr joel. But had some style issues. I have covered all the suggestions. Do any more changes need to be made before it is merged?
Thanks -Eshan On Sat, Apr 4, 2020 at 12:46 AM Eshan dhawan <eshandhawa...@gmail.com> wrote: > --- > testsuites/psxtests/psxinttypes01/init.c | 28 +++++++++++++++++-- > .../psxtests/psxinttypes01/psxinttypes01.doc | 10 ++++++- > 2 files changed, 34 insertions(+), 4 deletions(-) > > diff --git a/testsuites/psxtests/psxinttypes01/init.c > b/testsuites/psxtests/psxinttypes01/init.c > index 030aa2aa57..28f7336fb8 100644 > --- a/testsuites/psxtests/psxinttypes01/init.c > +++ b/testsuites/psxtests/psxinttypes01/init.c > @@ -6,6 +6,7 @@ > /* > * SPDX-License-Identifier: BSD-2-Clause > * > + * Copyright (C) 2020, Eshan Dhawan > * Copyright (C) 2019, Aditya Upadhyay and Vaibhav Gupta > * > * Redistribution and use in source and binary forms, with or without > @@ -64,11 +65,32 @@ rtems_task Init(rtems_task_argument ignored) > wchar_t *nptr2_n_errange = L"-9999999999999999999999"; > wchar_t *endptr2 = NULL; > > - intmax_t result_strtoimax; > + intmax_t result_strtoimax, result_imaxabs, input_1, input_2; > + imaxdiv_t result_exp, result_imaxdiv; > uintmax_t result_strtoumax; > > TEST_BEGIN(); > - > + > + /* Test for imaxabs */ > + input_1 = -10; > + result_imaxabs = 10; > + rtems_test_assert( imaxabs(input_1) == result_imaxabs ); > + > + input_1 = 10; > + result_imaxabs = 10; > + rtems_test_assert( imaxabs(input_1) == result_imaxabs ); > + > + /* Test for imaxdiv */ > + input_1 = 10; > + input_2 = 3; > + result_exp.quot = input_1 / input_2; > + result_exp.rem = input_1 % input_2; > + result_imaxdiv = imaxdiv( input_1, input_2 ); > + rtems_test_assert( > + result_imaxdiv.quot == result_exp.quot && > + result_imaxdiv.rem == result_exp.rem > + ); > + > /* Test for strtoimax */ > puts( "\nstrtoimax Testcases...." ); > puts( "Valid Inputs - Positive Number" ); > @@ -83,7 +105,7 @@ rtems_task Init(rtems_task_argument ignored) > rtems_test_assert( result_strtoimax == -123 ); > > puts( "Final string pointed by endptr" ); > - rtems_test_assert( endptr1 == ( nptr1_n + 4 ) ); > + rtems_test_assert( endptr1 == ( nptr1_n + 4 ) ); > > puts( "Valid Input - Positive Number - Number out of Range" ); > result_strtoimax = strtoimax( nptr1_p_errange, &endptr1, base ); > diff --git a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc > b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc > index 19f63af34b..59b76796e2 100644 > --- a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc > +++ b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc > @@ -1,4 +1,4 @@ > -This File describes the concepts tested by this test suite. > +This File describes the concepts tested by this test suite. > > inttypes.h - fixed size integer types > > @@ -37,3 +37,11 @@ test suite name: PSXINTTYPE 01 > - checks for output for string having a negative number - Number > Out of Range > - checks for final string pointed by endptr > - checks for output for invalid argument - Invalid Base > + > +- Checks for imaxabs Testcases > + - checks for output with an input with any negative number > + - checks for output with an input with any positive number > + > +- Checks for imaxdiv Testcases > + - checks for the output quotient and remainder with input with > positive numbers > + > -- > 2.17.1 > >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
