On Fri, Mar 13, 2020 at 2:04 PM Richi Dubey <richidu...@gmail.com> wrote:
>
> Dear Dr. Bloom,
>
> Please find my patch given below :-
>
> From 296fa828fec7c3f99231b377c57ca20411564703 Mon Sep 17 00:00:00 2001
> From: Richi Dubey <richidu...@gmail.com>
> Date: Sat, 14 Mar 2020 01:33:02 +0530
> Subject: [PATCH 2/2] Changed the hello world file
>
> ---
> testsuites/samples/hello/init.c | 43 +++++++++++----------------------
> 1 file changed, 14 insertions(+), 29 deletions(-)
>
> diff --git a/testsuites/samples/hello/init.c b/testsuites/samples/hello/init.c
> index 34ded37c55..e29306e7c9 100644
> --- a/testsuites/samples/hello/init.c
> +++ b/testsuites/samples/hello/init.c
> @@ -1,44 +1,29 @@
> -/*
> - * COPYRIGHT (c) 1989-2012.
> - * On-Line Applications Research Corporation (OAR).
> - *
> - * The license and distribution terms for this file may be
> - * found in the file LICENSE in this distribution or at
> - * http://www.rtems.org/license/LICENSE.
> - */
> -
It is incorrect to remove someone else's copyright and licensing information.
> -#ifdef HAVE_CONFIG_H
> -#include "config.h"
> -#endif
> -
> #include <rtems.h>
> -#include <tmacros.h>
> +#include <stdlib.h>
> +#include <stdio.h>
>
> -const char rtems_test_name[] = "HELLO WORLD";
> -
> -static rtems_task Init(
> +rtems_task Init(
> rtems_task_argument ignored
> )
> {
> - rtems_print_printer_fprintf_putc(&rtems_test_printer);
> - TEST_BEGIN();
> - printf( "Hello World\n" );
> - TEST_END();
> - rtems_test_exit( 0 );
> + printf( "\n\n*** Hello RTEMS 2020! Let's do something new :) ***\n" );
> + printf( "Hello Everyone\n" );
> + printf( "*** Bubyee ***\n" );
> + exit( 0 );
Although you were successful, this patch includes a lot of unnecessary
changes. When you work on code and do submit patches, you should
minimize non-relevant changes.
> }
>
> +/* configuration information */
> +
> +#include <bsp.h>
>
> /* NOTICE: the clock driver is explicitly disabled */
> #define CONFIGURE_APPLICATION_DOES_NOT_NEED_CLOCK_DRIVER
> -#define CONFIGURE_APPLICATION_NEEDS_SIMPLE_CONSOLE_DRIVER
> -
> -#define CONFIGURE_MAXIMUM_TASKS 1
> +#define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER
> +#define CONFIGURE_USE_DEVFS_AS_BASE_FILESYSTEM
>
> #define CONFIGURE_RTEMS_INIT_TASKS_TABLE
> -
> -#define CONFIGURE_INIT_TASK_ATTRIBUTES RTEMS_FLOATING_POINT
> -
> -#define CONFIGURE_INITIAL_EXTENSIONS RTEMS_TEST_INITIAL_EXTENSION
> +#define CONFIGURE_MAXIMUM_TASKS 1
>
> #define CONFIGURE_INIT
> #include <rtems/confdefs.h>
> +/* end of file */
> --
> 2.17.1
>
> On Fri, Mar 13, 2020 at 12:54 AM Gedare Bloom <ged...@rtems.org> wrote:
> >
> > On Thu, Mar 12, 2020 at 1:23 PM Gedare Bloom <ged...@rtems.org> wrote:
> > >
> > > Hi Richi,
> > >
> > > Welcome. The "Improve the SMP Scheduler" will require strong C
> > > programming skills before the summer. You will be expected to
> > > demonstrate that during the proposal period. I'm the only likely
> > > mentor for that project this year, and I haven't decided if I will
> > > mentor any projects, or which project I might mentor if I do. So it
> > > can be a bit risky to pursue that project, but if you are passionate
> > > about it and have the required capabilities, then you should start to
> > > prepare a proposal and convince me that I should mentor you :).
> > >
> > > The project itself is a straightforward implementation from the
> > > current skeleton of the scheduler. So you will want to also include
> > > some "extension" activities in case you complete the scheduler
> > > quickly.
> > >
> > > You should add yourself to https://devel.rtems.org/wiki/GSoC/2020
> > >
> > PS: thanks for the screenshot, please send your patch as well.
> >
> > > Gedare
> > >
> > > On Thu, Mar 12, 2020 at 1:04 PM Richi Dubey <richidu...@gmail.com> wrote:
> > > >
> > > > Hey everyone,
> > > >
> > > > Could someone please tell me if this project
> > > > (https://devel.rtems.org/ticket/2510) titled
> > > > "Improve the SMP scheduler with arbitrary processor affinity support"
> > > > still open? I went through the mpi-sws paper and I found the concept
> > > > of implementing
> > > > task's affinity to a processor to increase its efficiency really
> > > > interesting. Can someone please help me with this?
> > > >
> > > > Thanks,
> > > > Richi.
> > > > _______________________________________________
> > > > devel mailing list
> > > > devel@rtems.org
> > > > http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
