On 10/12/19 5:05 pm, Sebastian Huber wrote: > On 10/12/2019 00:28, chr...@rtems.org wrote: >> This patch adds C++ thread support that is similar to the standard >> C++ std::thread class however it has attributes so you can control >> a thread priority, stack size and other attributes. > > looks good, but I don't like the short library name. I think it should start > with librtems* just like the other RTEMS libraries.
I found doorstop or YAML or something did not like the ++ in a file name so I switched to using xx. What about librtemscxx? This means the library and spec file names match? > Maybe librtems++.a even though we had such a library before. I decided not to copy the same name because it could incorrectly be associated with the old library. >> The patch is against Sebastian's waf build repo. I would like it >> say it was a pleasure to add the new files to the new build system. >> Well done Sebastian it is really great. > > Thanks for testing the new build system. It was easy. I did notice when I followed the eng manual's guide to adding a test the created build type was object and not test-program and that confused me. Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
