I have a pending partial review which seconds Sebastian's opinion. Most notably, the clock, btimer drivers code duplicate most of the existing riscv drivers. It might be easier to just use the existing generic riscv BSP ones, and if they lack any features, you can fix that. Also, all of the csr_*() functions are already defined in the riscv-utility.h header.
On Thu, 29 Aug 2019 at 07:19, Sebastian Huber <sebastian.hu...@embedded-brains.de> wrote: > > Hello Pragnesh Patel, > > thanks for your patch. This patch contains a bit of copy and paste which > may make the maintenance of the port harder. In general, why can't you > add the support to the generic riscv BSP? > > -- > Sebastian Huber, embedded brains GmbH > > Address : Dornierstr. 4, D-82178 Puchheim, Germany > Phone : +49 89 189 47 41-16 > Fax : +49 89 189 47 41-09 > E-Mail : sebastian.hu...@embedded-brains.de > PGP : Public key available on request. > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel -- Hesham _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
