On 12/08/2019 12:27, Ravindra Kumar Meena wrote:
This is too complicated:
+ strcpy( filename, "event_" );
snprintf( file_index, sizeof( file_index ), "%ld", i );
strcat( filename, file_index );
In addition, the strcpy() and strcat() functions are dangerous to use.
Why don't you simply use:
snprintf( filename, sizeof( filename ), "event_%zu", i );
?
The i is of type size_t, so %ld is not the right format. Firstly, the
signedness is wrong, secondly using "l" is not portable.
Okay
https://github.com/rmeena840/rtems-tools/commit/1ffbe7d5dcea741a3e7ceec8ded869d38c20081f
Have a look.
What's the procedure for getting code merged? Do I have to raise PR on
GitHub or simply send a patch on devel?
First we have to integrate the initial support for the rtems-record program:
https://lists.rtems.org/pipermail/devel/2019-August/027278.html
Then you can rebase your work on top of it and send a single patch to
devel@rtems.org for the normal patch review.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
