On 26/07/2019 13:22, Vijay Kumar Banerjee wrote: > --- > freebsd/sys/arm/ti/am335x/am335x_ecap.c | 202 ++++ > freebsd/sys/arm/ti/am335x/am335x_lcd.c | 1085 ++++++++++++++++++++++ > freebsd/sys/arm/ti/am335x/am335x_lcd.h | 60 ++ > freebsd/sys/arm/ti/am335x/am335x_pwm.h | 35 + > freebsd/sys/arm/ti/am335x/am335x_pwmss.c | 165 ++++ > freebsd/sys/dev/fb/fbreg.h | 345 +++++++ > freebsd/sys/dev/syscons/syscons.h | 693 ++++++++++++++ > freebsd/sys/dev/vt/vt.h | 474 ++++++++++
Wouldn't that belong to the VT part? If that header is included here I would say VT is a prerequisite for am335x_lcd. Regarding the whole order stuff: I already mentioned, that (as long as each patch is compilable) I more or less will accept any order. The current one is just a bit odd. With your current order, the am335x_lcd wouldn't be useable before the later fbd and VT is imported. So in that patch version there is a driver that would not run. On the other hand VT could be used with some other driver too (for example if someone forks from that version). So in my eyes, VT and fbd are prerequisites for am335x_lcd. > freebsd/sys/sys/consio.h | 468 ++++++++++ > freebsd/sys/sys/fbio.h | 622 +++++++++++++ > freebsd/sys/sys/terminal.h | 240 +++++ > freebsd/sys/teken/teken.h | 221 +++++ > 12 files changed, 4610 insertions(+) > create mode 100644 freebsd/sys/arm/ti/am335x/am335x_ecap.c > create mode 100644 freebsd/sys/arm/ti/am335x/am335x_lcd.c > create mode 100644 freebsd/sys/arm/ti/am335x/am335x_lcd.h > create mode 100644 freebsd/sys/arm/ti/am335x/am335x_pwm.h > create mode 100644 freebsd/sys/arm/ti/am335x/am335x_pwmss.c > create mode 100644 freebsd/sys/dev/fb/fbreg.h > create mode 100644 freebsd/sys/dev/syscons/syscons.h > create mode 100644 freebsd/sys/dev/vt/vt.h > create mode 100644 freebsd/sys/sys/consio.h > create mode 100644 freebsd/sys/sys/fbio.h > create mode 100644 freebsd/sys/sys/terminal.h > create mode 100644 freebsd/sys/teken/teken.h > [...] _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
