On 18/06/2019 21:53, Vijay Kumar Banerjee wrote: > > This Patch series contains the patches to import and port > the drivers for FB and TDA from FreeBSD. This is not a working > patch and the purpose of sending the patch to the list is to > ask for a help regarding a build issue with the FB files that > use /arm/include/bus.h file. > In rtemsbsd/ we have the bus.h file for RTEMS and I think that > is the one to be used by the drivers and the bus.h is not > supposed to be imported from the FreeBSD. The error I'm > seeing is this: > > ``` > ../../freebsd/sys/dev/vt/hw/fb/vt_early_fb.c:244:7: error: > 'BUS_SPACE_MAP_PREFETCHABLE' undeclared (first use in this function); did you > mean 'BUS_SPACE_MAXSIZE_32BIT'? > BUS_SPACE_MAP_PREFETCHABLE, > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > BUS_SPACE_MAXSIZE_32BIT > ``` > After a discussion with the mentors, Christian told me that > most likely RTEMS doesn't use the 'bus_space_map' flags. > > Should I use "#ifndef __rtems__" codeguards to ommit this > from the build? How to deal with this error here ?
It seems that we don't have these flags in our RTEMS bus.h. I'm not sure whether it is better to add them to bus.h (and ignore them like done now) or to remove the part with ifdefs. I would lean to the first method: Adding them to bus.h. > > Thanks, > Vijay > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
