Same comment about claiming the task as the other patch. Submit as part of the GCI task so you get credit. I will merge from there
On this one, I am going to add that the code should build without warnings. Just visually reviewing, I see some variables which look to be uninitialized. Please ensure there are no warnings. Also for methods which take constant/enumerated values for arguments, pick one from the set, assign it to a variable, and pass that in. --joel On Tue, Dec 4, 2018 at 3:18 AM Abhimanyu Raghuvanshi < abhimanyuraghuvansh...@gmail.com> wrote: > From f2f64afbf8933adbec22ad6b4991fbcbe5461a53 Mon Sep 17 00:00:00 2001 > From: ABR290B <abhimanyuraghuvansh...@gmail.com> > Date: Tue, 4 Dec 2018 14:45:33 +0530 > Subject: [PATCH] Implement POSIX API Signature Compliance Tests for > arpa/inet.h (GCI2018) > > --- > testsuites/psxtests/Makefile.am | 13 ++++++- > .../psxtests/psxhdrs/fenv/feclearexcept.c | 34 ++++++++++++++++++ > testsuites/psxtests/psxhdrs/fenv/fegetenv.c | 34 ++++++++++++++++++ > .../psxtests/psxhdrs/fenv/fegetexceptflag.c | 35 +++++++++++++++++++ > testsuites/psxtests/psxhdrs/fenv/fegetround.c | 34 ++++++++++++++++++ > .../psxtests/psxhdrs/fenv/feholdexcept.c | 34 ++++++++++++++++++ > .../psxtests/psxhdrs/fenv/feraiseexcept.c | 34 ++++++++++++++++++ > testsuites/psxtests/psxhdrs/fenv/fesetenv.c | 34 ++++++++++++++++++ > .../psxtests/psxhdrs/fenv/fesetexceptflag.c | 35 +++++++++++++++++++ > testsuites/psxtests/psxhdrs/fenv/fesetround.c | 34 ++++++++++++++++++ > .../psxtests/psxhdrs/fenv/fetestexcept.c | 34 ++++++++++++++++++ > .../psxtests/psxhdrs/fenv/feupdateenv.c | 34 ++++++++++++++++++ > 12 files changed, 388 insertions(+), 1 deletion(-) > create mode 100644 testsuites/psxtests/psxhdrs/fenv/feclearexcept.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/fegetenv.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/fegetexceptflag.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/fegetround.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/feholdexcept.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/feraiseexcept.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/fesetenv.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/fesetexceptflag.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/fesetround.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/fetestexcept.c > create mode 100644 testsuites/psxtests/psxhdrs/fenv/feupdateenv.c > > diff --git a/testsuites/psxtests/Makefile.am > b/testsuites/psxtests/Makefile.am > index c27f213959..633b2efab1 100644 > --- a/testsuites/psxtests/Makefile.am > +++ b/testsuites/psxtests/Makefile.am > @@ -1126,7 +1126,18 @@ lib_a_SOURCES = psxhdrs/devctl/posix_devctl.c \ > psxhdrs/arpa/inet/inet_addr.c \ > psxhdrs/arpa/inet/inet_ntoa.c \ > psxhdrs/arpa/inet/inet_pton.c \ > - psxhdrs/arpa/inet/inet_ntop.c > + psxhdrs/arpa/inet/inet_ntop.c \ > + psxhdrs/penv/feclearexcept.c \ > + psxhdrs/penv/fegetenv.c \ > + psxhdrs/penv/fegetexcept.c \ > + psxhdrs/penv/fegetround.c \ > + psxhdrs/penv/feholdexcept.c \ > + psxhdrs/penv/feraiseexcept.c \ > + psxhdrs/penv/fesetenv.c \ > + psxhdrs/penv/fesetexceptflag.c \ > + psxhdrs/penv/fesetround.c \ > + psxhdrs/penv/fesetexcept.c \ > + psxhdrs/penv/feupdateenv.c > endif > > rtems_tests_PROGRAMS = $(psx_tests) > diff --git a/testsuites/psxtests/psxhdrs/fenv/feclearexcept.c > b/testsuites/psxtests/psxhdrs/fenv/feclearexcept.c > new file mode 100644 > index 0000000000..1ecb53ab4a > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/feclearexcept.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief feclearexcept() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + int b; > + return feclearexcept(b); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/fegetenv.c > b/testsuites/psxtests/psxhdrs/fenv/fegetenv.c > new file mode 100644 > index 0000000000..b01b06af6a > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/fegetenv.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief fegetenv() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + fenv_t *a; > + return fegetenv(a); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/fegetexceptflag.c > b/testsuites/psxtests/psxhdrs/fenv/fegetexceptflag.c > new file mode 100644 > index 0000000000..5f18c95d7f > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/fegetexceptflag.c > @@ -0,0 +1,35 @@ > +/** > + * @file > + * @brief fegetexceptflag() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + int a; > + fexcept_t *b; > + return fegetexceptflag(b, a); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/fegetround.c > b/testsuites/psxtests/psxhdrs/fenv/fegetround.c > new file mode 100644 > index 0000000000..dcf4274cba > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/fegetround.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief fegetround() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + void a; > + return fegetround(a); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/feholdexcept.c > b/testsuites/psxtests/psxhdrs/fenv/feholdexcept.c > new file mode 100644 > index 0000000000..43cf2729bf > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/feholdexcept.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief feholfexcept() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + fenv_t *a; > + return feholfexcept(a); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/feraiseexcept.c > b/testsuites/psxtests/psxhdrs/fenv/feraiseexcept.c > new file mode 100644 > index 0000000000..1d06d673e6 > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/feraiseexcept.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief feraiseexcept() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + int b; > + return feraiseexcept(b); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/fesetenv.c > b/testsuites/psxtests/psxhdrs/fenv/fesetenv.c > new file mode 100644 > index 0000000000..240dc31e6e > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/fesetenv.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief fesetenv() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + const fenv_t *a; > + return fesetenv(a); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/fesetexceptflag.c > b/testsuites/psxtests/psxhdrs/fenv/fesetexceptflag.c > new file mode 100644 > index 0000000000..7d2e228e8c > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/fesetexceptflag.c > @@ -0,0 +1,35 @@ > +/** > + * @file > + * @brief fesetexceptflag() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + int a; > + const fexcept_t *b; > + return fesetexceptflag(b, a); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/fesetround.c > b/testsuites/psxtests/psxhdrs/fenv/fesetround.c > new file mode 100644 > index 0000000000..51522f08b8 > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/fesetround.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief fesetround() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + int b; > + return fesetround(b); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/fetestexcept.c > b/testsuites/psxtests/psxhdrs/fenv/fetestexcept.c > new file mode 100644 > index 0000000000..c999357bf9 > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/fetestexcept.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief fetestexcept() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + int b; > + return fetestexcept(b); > +} > \ No newline at end of file > diff --git a/testsuites/psxtests/psxhdrs/fenv/feupdateenv.c > b/testsuites/psxtests/psxhdrs/fenv/feupdateenv.c > new file mode 100644 > index 0000000000..d8340bb49a > --- /dev/null > +++ b/testsuites/psxtests/psxhdrs/fenv/feupdateenv.c > @@ -0,0 +1,34 @@ > +/** > + * @file > + * @brief feupdateenv() API Conformance Test > + */ > + > +/* > + * COPYRIGHT (c) 2018. > + * Abhimanyu Raghuvanshi > + * > + * Permission to use, copy, modify, and/or distribute this software > + * for any purpose with or without fee is hereby granted. > + * > + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL > + * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED > + * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE > AUTHOR > + * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES > + * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, > + * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, > + * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS > SOFTWARE. > + */ > + > +#ifdef HAVE_CONFIG_H > +#include "config.h" > +#endif > + > +#include <fenv.h> > + > +int test(void); > + > +int test(void) > +{ > + const fenv_t *a; > + return feupdateenv(a); > +} > \ No newline at end of file > > 送られた ABR2908 > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel