On 09/10/2018 14:50, Chris Johns wrote:
On 8/10/18 10:35 pm, Sebastian Huber wrote:
On 09/10/2018 03:41, Chris Johns wrote:
On 8/10/18 3:43 am, Sebastian Huber wrote:
Update #3375.
Why?
To keep the count of  command line arguments small. These three header files are
used only in the shell directory. They are not installed.
Thanks, I see the issue now. This is a limitation of building this way. Waf
allows options to added based on grouping of source.

The <err.h> and <fts.h> are candidates for Newlib. It is a bit of work to make
them available via Newlib since they are already provided by Cygwin. This patch
set is a preparation for this:

https://sourceware.org/ml/newlib/2018/msg01004.html
Nice.

Some of these files are imported ....

---
   cpukit/libmisc/Makefile.am              | 1 -
   cpukit/libmisc/shell/cmp-ls.c           | 2 +-
... for this example this file.
I don't think the changed #include statements will cause major problems if
someone decides to merge upstream patches.
Yes I agree. The change is fine.

Thanks for the review, can I check in the complete patch set?

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to