On Wed, May 23, 2018, 10:01 PM Chris Johns <chr...@rtems.org> wrote:
> On 24/5/18 12:07 pm, Joel Sherrill wrote:
> > ---
> > tester/covoar/Target_sparc.cc | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tester/covoar/Target_sparc.cc
> b/tester/covoar/Target_sparc.cc
> > index 0e4ab2e..deeafef 100644
> > --- a/tester/covoar/Target_sparc.cc
> > +++ b/tester/covoar/Target_sparc.cc
> > @@ -64,6 +64,10 @@ namespace Target {
> > size = 4;
> > return true;
> > }
> > + if (!strcmp( &line[strlen(line)-6], "unimpl")) {
>
It's matching the last N characters on the line. It should be backing off
one extra for a new line.
> I have not looked at the code around this for C++.
>
> Also these calls should be "::strcmp()".
>
Ok. The same pattern is every Target*.cc
>
> Chris
>
> > + size = 4;
> > + return true;
> > + }
> >
> > if (!strcmp( &line[strlen(line)-7], "unknown")) {
> > size = 4;
> >
>
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
