On Fri, May 18, 2018 at 8:44 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote:
> On 18/05/18 15:42, Joel Sherrill wrote: > >> >> >> On Fri, May 18, 2018 at 8:25 AM, Sebastian Huber < >> sebastian.hu...@embedded-brains.de <mailto:sebastian.huber@embedd >> ed-brains.de>> wrote: >> >> On 18/05/18 15:21, Joel Sherrill wrote: >> >> >> >> On Fri, May 18, 2018 at 12:41 AM, Sebastian Huber >> <sebastian.hu...@embedded-brains.de >> <mailto:sebastian.hu...@embedded-brains.de> >> <mailto:sebastian.hu...@embedded-brains.de >> >> <mailto:sebastian.hu...@embedded-brains.de>>> wrote: >> >> On 16/05/18 17:09, Joel Sherrill wrote: >> >> Updates #3425. >> --- >> bsps/powerpc/beatnik/config/beatnik.cfg | 2 +- >> c/src/lib/libbsp/powerpc/beatnik/configure.ac >> <http://configure.ac> >> <http://configure.ac> | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/bsps/powerpc/beatnik/config/beatnik.cfg >> b/bsps/powerpc/beatnik/config/beatnik.cfg >> index 1190cad..05bea38 100644 >> --- a/bsps/powerpc/beatnik/config/beatnik.cfg >> +++ b/bsps/powerpc/beatnik/config/beatnik.cfg >> @@ -14,7 +14,7 @@ RTEMS_BSP_FAMILY=beatnik >> # This contains the compiler options necessary to >> select >> the CPU model >> # and (hopefully) optimize for it. >> # >> -CPU_CFLAGS = -mcpu=7400 -D__ppc_generic >> +CPU_CFLAGS = -mcpu=7400 >> #T. Straumann; disable sdata=eabi for now until CEXP >> supports it -meabi -msdata=eabi >> # optimize flag: typically -0, could use -O4 or -fast >> diff --git >> a/c/src/lib/libbsp/powerpc/beatnik/configure.ac >> <http://configure.ac> >> <http://configure.ac> >> b/c/src/lib/libbsp/powerpc/beatnik/configure.ac >> <http://configure.ac> >> <http://configure.ac> >> index a48007c..b332aaa 100644 >> --- a/c/src/lib/libbsp/powerpc/beatnik/configure.ac >> <http://configure.ac> >> <http://configure.ac> >> +++ b/c/src/lib/libbsp/powerpc/beatnik/configure.ac >> <http://configure.ac> >> <http://configure.ac> >> @@ -34,6 +34,8 @@ Note that the policy can still be >> defined by >> the application >> CONFIGURE_MALLOC_BSP_SUPPORTS_SBRK this feature is >> removed >> and a little memory is saved.]) >> +AC_DEFINE(__ppc_generic, 1, [PowerPC model option]) >> + >> # Explicitly list all Makefiles here >> AC_CONFIG_FILES([Makefile]) >> >> >> I would rather eliminate the only user of __ppc_generic in >> bsps/powerpc/include/rtems/powerpc/powerpc.h. >> >> >> I have file another ticket #3431 to address this and assigned >> it to you. >> >> I am committing my changes because they eliminate use of -D on >> the GCC command line >> and allow packages using rtems_waf to compile. >> >> >> Did you check that every consumer of these defines includes >> <bspopts.h> somehow? >> >> >> powerpc.h fails to compile if it isn't provided. >> > > Are these defines only used in powerpc.h? $ grep -lr __ppc_generic . ./c/src/lib/libbsp/powerpc/beatnik/configure.ac ./c/src/lib/libbsp/powerpc/motorola_powerpc/configure.ac ./c/src/lib/libbsp/powerpc/mpc55xxevb/configure.ac ./c/src/lib/libbsp/powerpc/mvme3100/configure.ac ./c/src/lib/libbsp/powerpc/qoriq/configure.ac ./c/src/lib/libbsp/powerpc/t32mppc/configure.ac ./bsps/powerpc/include/rtems/powerpc/powerpc.h I didn't check the others. If it broke something because someone wasn't writing defensive enough ifdef's, then that code should be fixed to be more defensive. powerpc.h had a default to #error > > > -- > Sebastian Huber, embedded brains GmbH > > Address : Dornierstr. 4, D-82178 Puchheim, Germany > Phone : +49 89 189 47 41-16 > Fax : +49 89 189 47 41-09 > E-Mail : sebastian.hu...@embedded-brains.de > PGP : Public key available on request. > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. > >
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
