On 09/04/2018 23:58, Christian Mauderer wrote: > Sorry, missed the subject line in git send-email. This description is to > the v2-patch-set for the libbsd waf changes. > > Am 09.04.2018 um 15:53 schrieb Christian Mauderer: >> Hello, >> >> this version now contains some changes like discussed with Chris Johns: >> >> - I moved the fragment composers to builder.py. With that the >> freebsd_to_rtems dependency to waf_libbsd is removed again. >> - The ini files have now a section "modules" instead of >> "modules-enabled". The modules are now switched "on" and "off" >> (instead of 1 and 0). >> - README.waf now contains a note about the default case. >>
Looks good. A minor thing, in wscript can we remove '#import libbsd_waf'? >> Beneath that I had a problem with a second configure call using cached >> values from a .lock-waf_linux2_build file. Therefore I changed how and >> when the builders are generated in wscript. I agree with the comments and I do not have a better solution. I may ask Thomas (irc: ita) to review and provide some feedback once in the repo. >> Again: Any feedback is welcome. Please push when ready. Thank you for this work. Chris _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
