You can try to share this file (with RISC-V based BSPs and other shared linkcmds if any that are arch-independent) and avoid duplications, and only include the relevant parts of your HiFive boards, similar to ARM-based BSPs.
It's important you try to address comments/feedback; students should go through the code review process, etc it's one of the goals of Google Summer of Code and open-source involvement. On Fri, Aug 18, 2017 at 2:59 AM, Denis Obrezkov <denisobrez...@gmail.com> wrote: > 2017-08-17 16:57 GMT+02:00 Gedare Bloom <ged...@rtems.org>: >> >> On Wed, Aug 16, 2017 at 11:12 AM, Denis Obrezkov >> <denisobrez...@gmail.com> wrote: >> > --- >> > c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds | 379 >> > ++++++++++++++++++++++ >> > 1 file changed, 379 insertions(+) >> > create mode 100644 c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds >> > >> > diff --git a/c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds >> > b/c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds >> > new file mode 100644 >> > index 0000000..8bf56a0 >> > --- /dev/null >> > +++ b/c/src/lib/libbsp/riscv32/hifive1/startup/linkcmds >> > @@ -0,0 +1,379 @@ >> > +/** >> > + * @file >> > + * >> > + * @ingroup bsp_linker >> > + * >> > + * @brief Memory map >> > + */ >> > + >> > +/* >> > + * >> > + * Copyright (c) 2015 University of York. >> > + * Hesham ALMatary <hmka...@york.ac.uk> >> > + * >> > + * Redistribution and use in source and binary forms, with or without >> > + * modification, are permitted provided that the following conditions >> > + * are met: >> > + * 1. Redistributions of source code must retain the above copyright >> > + * notice, this list of conditions and the following disclaimer. >> > + * 2. Redistributions in binary form must reproduce the above copyright >> > + * notice, this list of conditions and the following disclaimer in >> > the >> > + * documentation and/or other materials provided with the >> > distribution. >> > + * >> > + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' >> > AND >> > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, >> > THE >> > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR >> > PURPOSE >> > + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE >> > LIABLE >> > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >> > CONSEQUENTIAL >> > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE >> > GOODS >> > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS >> > INTERRUPTION) >> > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, >> > STRICT >> > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN >> > ANY WAY >> > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY >> > OF >> > + * SUCH DAMAGE. >> > + */ >> > + >> > +OUTPUT_FORMAT("elf32-littleriscv", "elf32-littleriscv", >> > "elf32-littleriscv") >> > +OUTPUT_ARCH (riscv) >> > + >> > +ENTRY (_start) >> > + >> > +MEMORY >> > +{ >> > + ROM : ORIGIN = 0x20400000, LENGTH = 16M >> > + RAM : ORIGIN = 0x80000000, LENGTH = 16K /* 64KiB external RAM, >> > but gdb knows only about 16 KiB */ >> Is there actually 64K ram? >> >> I don't have the knowledge to review the rest of this for correctness. >> It would be good to have a shared linkcmds approach though, like ARM. >> >> > + ITIM : ORIGIN = 0x08000000, LENGTH = 8K >> > +} >> > + >> > +REGION_ALIAS ("REGION_VECTOR", ROM); >> > +REGION_ALIAS ("REGION_START", ROM); >> > +REGION_ALIAS ("REGION_TEXT", ROM); >> > +REGION_ALIAS ("REGION_TEXT_LOAD", ROM); >> > +REGION_ALIAS ("REGION_RODATA", ROM); >> > +REGION_ALIAS ("REGION_RODATA_LOAD", ROM); >> > +REGION_ALIAS ("REGION_DATA", RAM); >> > +REGION_ALIAS ("REGION_DATA_LOAD", ROM); >> > +REGION_ALIAS ("REGION_FAST_DATA", RAM); >> > +REGION_ALIAS ("REGION_FAST_DATA_LOAD", ROM); >> > +REGION_ALIAS ("REGION_BSS", RAM); >> > +REGION_ALIAS ("REGION_WORK", RAM); >> > +REGION_ALIAS ("REGION_STACK", RAM); >> > + >> > +/* The following address is used for text output */ >> > +/* bsp_section_outbut_buffer = 0x8F800000; */ >> > + bsp_section_vector_begin = 0x20400000; >> > + >> > + >> > +STACK_LENGTH = 0; >> > +/* >> > + * Global symbols that may be defined externally >> > + */ >> > +bsp_vector_table_size = DEFINED (bsp_vector_table_size) ? >> > bsp_vector_table_size : 64; >> > + >> > +bsp_section_xbarrier_align = DEFINED (bsp_section_xbarrier_align) ? >> > bsp_section_xbarrier_align : 1; >> > +bsp_section_robarrier_align = DEFINED (bsp_section_robarrier_align) ? >> > bsp_section_robarrier_align : 1; >> > +bsp_section_rwbarrier_align = DEFINED (bsp_section_rwbarrier_align) ? >> > bsp_section_rwbarrier_align : 1; >> > + >> > +bsp_stack_align = DEFINED (bsp_stack_align) ? bsp_stack_align : 8; >> > + >> > +bsp_stack_main_size = DEFINED (bsp_stack_main_size) ? >> > bsp_stack_main_size : 1024; >> > +bsp_stack_main_size = ALIGN (bsp_stack_main_size, bsp_stack_align); >> > + >> > +_bsp_processor_count = DEFINED (_bsp_processor_count) ? >> > _bsp_processor_count : 1; >> > + >> > +SECTIONS { >> > + >> > + .vector : >> > + { >> > + . = 0x100; >> > + *(.vector) >> > + . = ALIGN(bsp_vector_table_size); >> > + bsp_section_vector_end = .; >> > + } > REGION_VECTOR AT > REGION_VECTOR >> > + bsp_section_vector_size = bsp_section_vector_end - >> > bsp_section_vector_begin; >> > + bsp_vector_table_begin = bsp_section_vector_begin; >> > + bsp_vector_table_end = bsp_vector_table_begin + >> > bsp_vector_table_size; >> > + >> > + .start : >> > + { >> > + . = ALIGN(8); >> > + bsp_section_start_begin = .; >> > + KEEP (*(.bsp_start_text)) >> > + KEEP (*(.bsp_start_data)) >> > + bsp_section_start_end = .; >> > + } > REGION_START AT > REGION_START >> > + bsp_section_start_size = bsp_section_start_end - >> > bsp_section_start_begin; >> > + >> > +.xbarrier : { >> > + . = ALIGN (bsp_section_xbarrier_align); >> > + } > REGION_VECTOR AT > REGION_VECTOR >> > + >> > +.text : { >> > + . = ALIGN(8); >> > + bsp_section_text_begin = .; >> > + *(.text.unlikely .text.*_unlikely) >> > + *(.text .stub .text.* .gnu.linkonce.t.*) >> > + /* .gnu.warning sections are handled specially by elf32.em. */ >> > + *(.gnu.warning) >> > + *(.glue_7t) *(.glue_7) *(.vfp11_veneer) *(.v4_bx) >> > + } > REGION_TEXT AT > REGION_TEXT_LOAD >> > + .init : { >> > + KEEP (*(.init)) >> > + } > REGION_TEXT AT > REGION_TEXT_LOAD >> > + .fini : { >> > + KEEP (*(.fini)) >> > + . = ALIGN(8); >> > + bsp_section_text_end = .; >> > + PROVIDE (__etext = .); >> > + PROVIDE (_etext = .); >> > + PROVIDE (etext = .); >> > + >> > + } > REGION_TEXT AT > REGION_TEXT_LOAD >> > + bsp_section_text_size = bsp_section_text_end - >> > bsp_section_text_begin; >> > + bsp_section_text_load_begin = LOADADDR (.text); >> > + bsp_section_text_load_end = bsp_section_text_load_begin + >> > bsp_section_text_size; >> > + >> > +.robarrier : { >> > + . = ALIGN (bsp_section_robarrier_align); >> > + } > REGION_RODATA AT > REGION_RODATA >> > + >> > +.rodata : { >> > + . = ALIGN(8); >> > + bsp_section_rodata_begin = .; >> > + *(.rodata .rodata.* .gnu.linkonce.r.*) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > +.eh_frame : { >> > + KEEP (*(.eh_frame)) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .gcc_except_table : { >> > + *(.gcc_except_table .gcc_except_table.*) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .tdata : { >> > + _TLS_Data_begin = .; >> > + *(.tdata .tdata.* .gnu.linkonce.td.*) >> > + _TLS_Data_end = .; >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .tbss : { >> > + _TLS_BSS_begin = .; >> > + *(.tbss .tbss.* .gnu.linkonce.tb.*) *(.tcommon) >> > + _TLS_BSS_end = .; >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + _TLS_Data_size = _TLS_Data_end - _TLS_Data_begin; >> > + _TLS_Data_begin = _TLS_Data_size != 0 ? _TLS_Data_begin : >> > _TLS_BSS_begin; >> > + _TLS_Data_end = _TLS_Data_size != 0 ? _TLS_Data_end : >> > _TLS_BSS_begin; >> > + _TLS_BSS_size = _TLS_BSS_end - _TLS_BSS_begin; >> > + _TLS_Size = _TLS_BSS_end - _TLS_Data_begin; >> > + _TLS_Alignment = MAX (ALIGNOF (.tdata), ALIGNOF (.tbss)); >> > + .preinit_array : { >> > + PROVIDE_HIDDEN (__preinit_array_start = .); >> > + KEEP (*(.preinit_array)) >> > + PROVIDE_HIDDEN (__preinit_array_end = .); >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .init_array : { >> > + PROVIDE_HIDDEN (__init_array_start = .); >> > + KEEP (*(SORT(.init_array.*))) >> > + KEEP (*(.init_array)) >> > + PROVIDE_HIDDEN (__init_array_end = .); >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .fini_array : { >> > + PROVIDE_HIDDEN (__fini_array_start = .); >> > + KEEP (*(.fini_array)) >> > + KEEP (*(SORT(.fini_array.*))) >> > + PROVIDE_HIDDEN (__fini_array_end = .); >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .ctors : { >> > + /* gcc uses crtbegin.o to find the start of >> > + the constructors, so we make sure it is >> > + first. Because this is a wildcard, it >> > + doesn't matter if the user does not >> > + actually link against crtbegin.o; the >> > + linker won't look for a file to match a >> > + wildcard. The wildcard also means that it >> > + doesn't matter which directory crtbegin.o >> > + is in. */ >> > + KEEP (*crtbegin.o(.ctors)) >> > + KEEP (*crtbegin?.o(.ctors)) >> > + /* We don't want to include the .ctor section from >> > + the crtend.o file until after the sorted ctors. >> > + The .ctor section from the crtend file contains the >> > + end of ctors marker and it must be last */ >> > + KEEP (*(EXCLUDE_FILE (*crtend.o *crtend?.o ) .ctors)) >> > + KEEP (*(SORT(.ctors.*))) >> > + KEEP (*(.ctors)) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .dtors : { >> > + KEEP (*crtbegin.o(.dtors)) >> > + KEEP (*crtbegin?.o(.dtors)) >> > + KEEP (*(EXCLUDE_FILE (*crtend.o *crtend?.o ) .dtors)) >> > + KEEP (*(SORT(.dtors.*))) >> > + KEEP (*(.dtors)) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .data.rel.ro : { >> > + *(.data.rel.ro.local* .gnu.linkonce.d.rel.ro.local.*) >> > + *(.data.rel.ro* .gnu.linkonce.d.rel.ro.*) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .jcr : { >> > + KEEP (*(.jcr)) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .interp : { >> > + *(.interp) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .note.gnu.build-id : { >> > + *(.note.gnu.build-id) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .hash : { >> > + *(.hash) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .gnu.hash : { >> > + *(.gnu.hash) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .dynsym : { >> > + *(.dynsym) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .dynstr : { >> > + *(.dynstr) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .gnu.version : { >> > + *(.gnu.version) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .gnu.version_d : { >> > + *(.gnu.version_d) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .gnu.version_r : { >> > + *(.gnu.version_r) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .rel.dyn : { >> > + *(.rel.init) >> > + *(.rel.text .rel.text.* .rel.gnu.linkonce.t.*) >> > + *(.rel.fini) >> > + *(.rel.rodata .rel.rodata.* .rel.gnu.linkonce.r.*) >> > + *(.rel.data.rel.ro* .rel.gnu.linkonce.d.rel.ro.*) >> > + *(.rel.data .rel.data.* .rel.gnu.linkonce.d.*) >> > + *(.rel.tdata .rel.tdata.* .rel.gnu.linkonce.td.*) >> > + *(.rel.tbss .rel.tbss.* .rel.gnu.linkonce.tb.*) >> > + *(.rel.ctors) >> > + *(.rel.dtors) >> > + *(.rel.got) >> > + *(.rel.bss .rel.bss.* .rel.gnu.linkonce.b.*) >> > + PROVIDE_HIDDEN (__rel_iplt_start = .); >> > + *(.rel.iplt) >> > + PROVIDE_HIDDEN (__rel_iplt_end = .); >> > + PROVIDE_HIDDEN (__rela_iplt_start = .); >> > + PROVIDE_HIDDEN (__rela_iplt_end = .); >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .rela.dyn : { >> > + *(.rela.init) >> > + *(.rela.text .rela.text.* .rela.gnu.linkonce.t.*) >> > + *(.rela.fini) >> > + *(.rela.rodata .rela.rodata.* .rela.gnu.linkonce.r.*) >> > + *(.rela.data .rela.data.* .rela.gnu.linkonce.d.*) >> > + *(.rela.tdata .rela.tdata.* .rela.gnu.linkonce.td.*) >> > + *(.rela.tbss .rela.tbss.* .rela.gnu.linkonce.tb.*) >> > + *(.rela.ctors) >> > + *(.rela.dtors) >> > + *(.rela.got) >> > + *(.rela.bss .rela.bss.* .rela.gnu.linkonce.b.*) >> > + PROVIDE_HIDDEN (__rel_iplt_start = .); >> > + PROVIDE_HIDDEN (__rel_iplt_end = .); >> > + PROVIDE_HIDDEN (__rela_iplt_start = .); >> > + *(.rela.iplt) >> > + PROVIDE_HIDDEN (__rela_iplt_end = .); >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .rel.plt : { >> > + *(.rel.plt) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .rela.plt : { >> > + *(.rela.plt) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .plt : { >> > + *(.plt) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .iplt : { >> > + *(.iplt) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .dynamic : { >> > + *(.dynamic) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .got : { >> > + *(.got.plt) *(.igot.plt) *(.got) *(.igot) >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + .rtemsroset : { >> > + /* Special FreeBSD linker set sections */ >> > + __start_set_sysctl_set = .; >> > + *(set_sysctl_*); >> > + __stop_set_sysctl_set = .; >> > + *(set_domain_*); >> > + *(set_pseudo_*); >> > + >> > + KEEP (*(SORT(.rtemsroset.*))) >> > + . = ALIGN(8); >> > + bsp_section_rodata_end = .; >> > + __data_start_rom = .; >> > + } > REGION_RODATA AT > REGION_RODATA_LOAD >> > + bsp_section_rodata_size = bsp_section_rodata_end - >> > bsp_section_rodata_begin; >> > + bsp_section_rodata_load_begin = LOADADDR (.rodata); >> > + bsp_section_rodata_load_end = bsp_section_rodata_load_begin + >> > bsp_section_rodata_size; >> > + >> > + >> > + >> > +.data : AT (__data_start_rom) { >> > + . = ALIGN(8); >> > + bsp_section_data_begin = .; >> > + PROVIDE (_copy_start = .); >> > + *(.data .data.* .gnu.linkonce.d.* .data1) >> > + SORT(CONSTRUCTORS) >> > + } > REGION_DATA >> > + .rtemsrwset : AT (__data_start_rom + SIZEOF (.data)) { >> > + KEEP (*(SORT(.rtemsrwset.*))) >> > + . = ALIGN(8); >> > + >> > + } > REGION_DATA >> > + bsp_section_data_size = bsp_section_data_end - >> > bsp_section_data_begin; >> > + bsp_section_data_load_begin = LOADADDR (.data); >> > + bsp_section_data_load_end = bsp_section_data_load_begin + >> > bsp_section_data_size; >> > + >> > +.rwbarrier : AT (__data_start_rom + SIZEOF (.data) + SIZEOF >> > (.rtemsrwset)) { >> > + . = ALIGN(8); >> > + . = ALIGN (bsp_section_rwbarrier_align); >> > + bsp_section_data_end = .; >> > + PROVIDE (_copy_end = .); >> > + } > REGION_DATA >> > + >> > + .bss : { >> > + . = ALIGN(8); >> > + bsp_section_bss_begin = .; >> > + *(.dynbss) >> > + *(.bss .bss.* .gnu.linkonce.b.*) >> > + *(COMMON) >> > + . = ALIGN(8); >> > + bsp_section_bss_end = .; >> > + } > REGION_BSS AT > REGION_BSS >> > + bsp_section_bss_size = bsp_section_bss_end - bsp_section_bss_begin; >> > + >> > +.work : { >> > + /* >> > + * The work section will occupy the remaining REGION_WORK region >> > and >> > + * contains the RTEMS work space and heap. >> > + */ >> > + . = ALIGN(8); >> > + bsp_section_work_begin = .; >> > + . += ORIGIN (REGION_WORK) + LENGTH (REGION_WORK) - ABSOLUTE (.) - >> > STACK_LENGTH; >> > + . = ALIGN(8); >> > + bsp_section_work_end = .; >> > + } > REGION_WORK AT > REGION_WORK >> > + bsp_section_work_size = bsp_section_work_end - >> > bsp_section_work_begin; >> > + >> > + .stack : { >> > + . = ALIGN(8); >> > + bsp_section_stack_begin = .; >> > + . += ORIGIN (REGION_STACK) + LENGTH (REGION_STACK) - ABSOLUTE (.); >> > + . = ALIGN(8); >> > + bsp_section_stack_end = .; >> > + } > REGION_STACK AT > REGION_STACK >> > + bsp_section_stack_size = bsp_section_stack_end - >> > bsp_section_stack_begin; >> > + >> > + RamBase = ORIGIN (REGION_WORK); >> > + RamSize = LENGTH (REGION_WORK); >> > + WorkAreaBase = bsp_section_work_begin; >> > + HeapSize = 0; >> > +} >> > -- >> > 2.1.4 >> > >> > _______________________________________________ >> > devel mailing list >> > devel@rtems.org >> > http://lists.rtems.org/mailman/listinfo/devel > > > Yes, there is only 16 KiB of RAM, should remove the comment. > I remember about linkcmds, but don't have time to implement it properly now. > > > -- > Regards, Denis Obrezkov > > _______________________________________________ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel -- Hesham _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel